[telemetry] Consolidate global hooks.

[telemetry] Consolidate global hooks.

Move exception_formatter from top level to util/.
Create util/global_hooks.py containing all these related things.
Add two new hooks:
- Stale .pyc check for base dir.
- Print a stack trace on SIGTERM.


BUG=None.
TEST=None.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259782

[dtu, 2014-03-19 21:14:46]

I don't know if this will help with anything, but it can't hurt.

[tonyg, 2014-03-20 00:20:29]

lgtm

[dtu, 2014-03-20 18:30:52]

The CQ bit was checked by dtu@chromium.org

[commit-bot: I haz the power, 2014-03-20 18:33:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dtu@chromium.org/205243003/20001

[commit-bot: I haz the power, 2014-03-20 18:33:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-20 18:33:25]

Failed to apply patch for tools/telemetry/telemetry/test_runner.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file tools/telemetry/telemetry/test_runner.py
  Hunk #2 succeeded at 95 with fuzz 2.
  Hunk #3 FAILED at 104.
  Hunk #4 succeeded at 226 (offset 51 lines).
  1 out of 4 hunks FAILED -- saving rejects to file
tools/telemetry/telemetry/test_runner.py.rej

Patch:       tools/telemetry/telemetry/test_runner.py
Index: tools/telemetry/telemetry/test_runner.py
diff --git a/tools/telemetry/telemetry/test_runner.py
b/tools/telemetry/telemetry/test_runner.py
index
ab2c81c389bc106086d818eb6e547e2c8f0a5100..6fa42c7615d030d8843ad29516f2cd1f4fbb7f0b
100644
--- a/tools/telemetry/telemetry/test_runner.py
+++ b/tools/telemetry/telemetry/test_runner.py
@@ -10,7 +10,9 @@ actually running the test is in Test and PageRunner."""
 import inspect
 import json
 import os
+import signal
 import sys
+import traceback
 
 from telemetry import test
 from telemetry.core import browser_options
@@ -93,7 +95,7 @@ class Run(command_line.OptparseCommand):
     if len(args.tests) != 1:
       print >> sys.stderr, 'Available tests are:'
       _PrintTestList(_Tests())
-      sys.exit(1)
+      sys.exit(-1)
 
     input_test_name = args.tests[0]
     matching_tests = _MatchTestName(input_test_name)
@@ -102,13 +104,13 @@ class Run(command_line.OptparseCommand):
       print >> sys.stderr
       print >> sys.stderr, 'Available tests:'
       _PrintTestList(_Tests())
-      sys.exit(1)
+      sys.exit(-1)
     if len(matching_tests) > 1:
       print >> sys.stderr, 'Multiple tests named "%s".' % input_test_name
       print >> sys.stderr
       print >> sys.stderr, 'Did you mean one of these?'
       _PrintTestList(matching_tests)
-      sys.exit(1)
+      sys.exit(-1)
 
     args.test = matching_tests.popitem()[1]
     args.test.ProcessCommandLineArgs(parser, args)
@@ -173,6 +175,14 @@ test_aliases = {}
 
 
 def Main():
+  # Catch SIGTERM and print a stack trace.
+  def PrintStackAndExit(sig, frame):
+    print >> sys.stderr, 'Traceback (most recent call last):'
+    traceback.print_stack(frame)
+    print >> sys.stderr, 'Received signal %s, exiting' % sig
+    sys.exit(-1)
+  signal.signal(signal.SIGTERM, PrintStackAndExit)
+
   # Get the command name from the command line.
   if len(sys.argv) > 1 and sys.argv[1] == '--help':
     sys.argv[1] = 'help'

[dtu, 2014-03-25 23:46:08]

PTAL. Changed the focus of this patch to have more cleanup.

[tonyg, 2014-03-26 01:35:17]

lgtm

https://chromiumcodereview.appspot.com/205243003/diff/60001/tools/telemetry/t...
File tools/telemetry/telemetry/util/global_hooks.py (right):

https://chromiumcodereview.appspot.com/205243003/diff/60001/tools/telemetry/t...
tools/telemetry/telemetry/util/global_hooks.py:29: sys.exit(1)
-1?

[dtu, 2014-03-26 01:58:46]

https://chromiumcodereview.appspot.com/205243003/diff/60001/tools/telemetry/t...
File tools/telemetry/telemetry/util/global_hooks.py (right):

https://chromiumcodereview.appspot.com/205243003/diff/60001/tools/telemetry/t...
tools/telemetry/telemetry/util/global_hooks.py:29: sys.exit(1)
On 2014/03/26 01:35:17, tonyg wrote:
> -1?

Done.

[jeremy, 2014-03-26 07:58:07]

Very nice cleanup! Thanks for doing this!

https://chromiumcodereview.appspot.com/205243003/diff/110001/tools/telemetry/...
File tools/telemetry/telemetry/__init__.py (right):

https://chromiumcodereview.appspot.com/205243003/diff/110001/tools/telemetry/...
tools/telemetry/telemetry/__init__.py:11: 
I would strongly prefer to keep the python version check here since it serves as
documentation to what version of Python Telemetry supports.

https://chromiumcodereview.appspot.com/205243003/diff/110001/tools/telemetry/...
File tools/telemetry/telemetry/util/global_hooks.py (right):

https://chromiumcodereview.appspot.com/205243003/diff/110001/tools/telemetry/...
tools/telemetry/telemetry/util/global_hooks.py:5: """When SIGUSR1 is received,
print a stack trace."""
I think you need to update this comment, I'd add a header comment here and a
line before each command in InstallHooks() explaining what the hook does.

https://chromiumcodereview.appspot.com/205243003/diff/110001/tools/telemetry/...
tools/telemetry/telemetry/util/global_hooks.py:62: def InstallDebuggingHook():
I know this is a name I picked, but I'd rename this to
InstallStackDumpOnSigusr1() or InstallStackTraceHook() ...

https://chromiumcodereview.appspot.com/205243003/diff/110001/tools/telemetry/...
tools/telemetry/telemetry/util/global_hooks.py:68: print """"SIGUSR1 received,
printing stack trace:
Again, my bad but could you change this to:
print >> sys.stderr,
to match InstallTerminationHook .

https://chromiumcodereview.appspot.com/205243003/diff/110001/tools/telemetry/...
tools/telemetry/telemetry/util/global_hooks.py:80: signal.signal(signal.SIGTERM,
PrintStackAndExit)
Do you need the same hasattr() as I added for SIGUSR1 ?

[dtu, 2014-03-26 20:08:16]

https://chromiumcodereview.appspot.com/205243003/diff/110001/tools/telemetry/...
File tools/telemetry/telemetry/__init__.py (right):

https://chromiumcodereview.appspot.com/205243003/diff/110001/tools/telemetry/...
tools/telemetry/telemetry/__init__.py:11: 
On 2014/03/26 07:58:08, jeremy wrote:
> I would strongly prefer to keep the python version check here since it serves
as
> documentation to what version of Python Telemetry supports.

Done.

https://chromiumcodereview.appspot.com/205243003/diff/110001/tools/telemetry/...
File tools/telemetry/telemetry/util/global_hooks.py (right):

https://chromiumcodereview.appspot.com/205243003/diff/110001/tools/telemetry/...
tools/telemetry/telemetry/util/global_hooks.py:5: """When SIGUSR1 is received,
print a stack trace."""
On 2014/03/26 07:58:08, jeremy wrote:
> I think you need to update this comment, I'd add a header comment here and a
> line before each command in InstallHooks() explaining what the hook does.

Done.

https://chromiumcodereview.appspot.com/205243003/diff/110001/tools/telemetry/...
tools/telemetry/telemetry/util/global_hooks.py:62: def InstallDebuggingHook():
On 2014/03/26 07:58:08, jeremy wrote:
> I know this is a name I picked, but I'd rename this to
> InstallStackDumpOnSigusr1() or InstallStackTraceHook() ...

Done.

https://chromiumcodereview.appspot.com/205243003/diff/110001/tools/telemetry/...
tools/telemetry/telemetry/util/global_hooks.py:68: print """"SIGUSR1 received,
printing stack trace:
On 2014/03/26 07:58:08, jeremy wrote:
> Again, my bad but could you change this to:
> print >> sys.stderr,
> to match InstallTerminationHook .

Done.

https://chromiumcodereview.appspot.com/205243003/diff/110001/tools/telemetry/...
tools/telemetry/telemetry/util/global_hooks.py:80: signal.signal(signal.SIGTERM,
PrintStackAndExit)
On 2014/03/26 07:58:08, jeremy wrote:
> Do you need the same hasattr() as I added for SIGUSR1 ?

Nope. "On Windows, signal() can only be called with SIGABRT, SIGFPE, SIGILL,
SIGINT, SIGSEGV, or SIGTERM."

[jeremy, 2014-03-26 20:10:48]

LGTM++

[nduca, 2014-03-26 20:49:53]

lgtm

[dtu, 2014-03-26 22:07:43]

The CQ bit was checked by dtu@chromium.org

[commit-bot: I haz the power, 2014-03-26 22:08:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dtu@chromium.org/205243003/180001

[commit-bot: I haz the power, 2014-03-27 00:36:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 00:36:37]

Retried try job too often on win_x64_rel for step(s) base_unittests,
chrome_elf_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...

[dtu, 2014-03-27 00:45:05]

The CQ bit was checked by dtu@chromium.org

[commit-bot: I haz the power, 2014-03-27 00:45:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dtu@chromium.org/205243003/180001

[commit-bot: I haz the power, 2014-03-27 04:26:19]

Change committed as 259782