third_party/WebKit/Source/core/html/track/TrackListBase.h - Issue 2050043002: Generate and assign media track ids in demuxers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/track/TrackListBase.h

Issue 2050043002: Generate and assign media track ids in demuxers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@use-streamparser-trackid

Patch Set: rebase to ToT Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/track/TrackBase.cpp ('k') | third_party/WebKit/Source/core/html/track/VideoTrack.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/track/TrackListBase.h

diff --git a/third_party/WebKit/Source/core/html/track/TrackListBase.h b/third_party/WebKit/Source/core/html/track/TrackListBase.h

index 778fd6133fee2ece7c59b0ad0c842401c76c0181..155eb97b552aa4df7d5266618351d01fd70b843b 100644

--- a/third_party/WebKit/Source/core/html/track/TrackListBase.h

+++ b/third_party/WebKit/Source/core/html/track/TrackListBase.h

@@ -36,7 +36,7 @@ public:

T* getTrackById(const String& id) const

{

for (unsigned i = 0; i < m_tracks.size(); ++i) {

- if (m_tracks[i]->id() == id)

+ if (String(m_tracks[i]->id()) == id)

return m_tracks[i].get();

}

@@ -65,7 +65,7 @@ public:

void remove(WebMediaPlayer::TrackId trackId)

{

for (unsigned i = 0; i < m_tracks.size(); ++i) {

- if (m_tracks[i]->trackId() != trackId)

+ if (m_tracks[i]->id() != trackId)

continue;

m_tracks[i]->setMediaElement(0);