media/blink/webmediaplayer_impl.cc - Issue 2050043002: Generate and assign media track ids in demuxers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/blink/webmediaplayer_impl.cc

Issue 2050043002: Generate and assign media track ids in demuxers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@use-streamparser-trackid

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/blink/webmediaplayer_impl.cc

diff --git a/media/blink/webmediaplayer_impl.cc b/media/blink/webmediaplayer_impl.cc

index 8f15f06060b6328560ae83e29d80d36ed8733d6a..2efdfe3812cca12039b444a55432d494941474bb 100644

--- a/media/blink/webmediaplayer_impl.cc

+++ b/media/blink/webmediaplayer_impl.cc

@@ -845,8 +845,7 @@ void WebMediaPlayerImpl::OnFFmpegMediaTracksUpdated(

for (const auto& track : tracks->tracks()) {

if (track->type() == MediaTrack::Audio) {

auto track_id = client_->addAudioTrack(

- blink::WebString::fromUTF8(

- base::UintToString(track->byteStreamTrackId())),

+ blink::WebString::fromUTF8(track->id()),

blink::WebMediaPlayerClient::AudioTrackKindMain,

blink::WebString::fromUTF8(track->label()),

blink::WebString::fromUTF8(track->language()),

@@ -854,8 +853,7 @@ void WebMediaPlayerImpl::OnFFmpegMediaTracksUpdated(

(void)track_id;

} else if (track->type() == MediaTrack::Video) {

auto track_id = client_->addVideoTrack(

- blink::WebString::fromUTF8(

- base::UintToString(track->byteStreamTrackId())),

+ blink::WebString::fromUTF8(track->id()),

blink::WebMediaPlayerClient::VideoTrackKindMain,

blink::WebString::fromUTF8(track->label()),

blink::WebString::fromUTF8(track->language()),

« media/base/media_tracks.cc ('K') | « media/base/mock_filters.h ('k') | media/blink/webmediaplayer_impl_unittest.cc » ('j') | media/blink/websourcebuffer_impl.cc » ('J')