Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Unified Diff: media/base/media_track.cc

Issue 2050043002: Generate and assign media track ids in demuxers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@use-streamparser-trackid
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/media_track.cc
diff --git a/media/base/media_track.cc b/media/base/media_track.cc
index 54aeb76ec21b4de4c12ede6fe6c99c8e584d0762..f46dc3c9502ea0c480fa361e4522201544afd6e5 100644
--- a/media/base/media_track.cc
+++ b/media/base/media_track.cc
@@ -15,8 +15,19 @@ MediaTrack::MediaTrack(Type type,
byteStreamTrackId_(byteStreamTrackId),
kind_(kind),
label_(label),
- language_(lang) {}
+ language_(lang),
+ id_("") {}
xhwang 2016/06/09 06:06:02 nit: not necessary
servolk 2016/06/09 19:14:46 Done.
MediaTrack::~MediaTrack() {}
+MediaTrack::TrackId MediaTrack::id() const {
+ return id_;
+}
+
+void MediaTrack::setId(TrackId id) {
+ DCHECK(id_ == "");
+ DCHECK(id != "");
xhwang 2016/06/09 06:06:02 nit: use empty()?
servolk 2016/06/09 19:14:46 Done.
+ id_ = id;
+}
xhwang 2016/06/09 06:06:02 nit: These two functions can be inlined in the hea
servolk 2016/06/09 19:14:46 Done.
+
} // namespace media

Powered by Google App Engine
This is Rietveld 408576698