Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: media/base/demuxer.h

Issue 2050043002: Generate and assign media track ids in demuxers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@use-streamparser-trackid
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/demuxer.h
diff --git a/media/base/demuxer.h b/media/base/demuxer.h
index 9c6607f9cb212555c5eee02d494b2b2e407d52a5..b113da60edf8d7652d2740d23a4551ff01c7c5f1 100644
--- a/media/base/demuxer.h
+++ b/media/base/demuxer.h
@@ -67,7 +67,7 @@ class MEDIA_EXPORT Demuxer : public DemuxerStreamProvider {
const std::vector<uint8_t>& init_data)>;
// Notifies demuxer clients that media track configuration has been updated
- // (e.g. the inital stream metadata has been parsed successfully, or a new
+ // (e.g. the initial stream metadata has been parsed successfully, or a new
// init segment has been parsed successfully in MSE case).
using MediaTracksUpdatedCB =
base::Callback<void(std::unique_ptr<MediaTracks>)>;
@@ -135,6 +135,9 @@ class MEDIA_EXPORT Demuxer : public DemuxerStreamProvider {
// Returns the memory usage in bytes for the demuxer.
virtual int64_t GetMemoryUsage() const = 0;
+ virtual const DemuxerStream* GetDemuxerStreamByTrackId(
xhwang 2016/06/09 06:06:02 This is actually not used in this CL. Also, in you
servolk 2016/06/09 19:14:46 At the moment I'm inclined to think it's better to
xhwang 2016/06/09 21:04:16 In general we don't add an API because it's generi
+ std::string track_id) const = 0;
xhwang 2016/06/09 06:06:02 const ref
servolk 2016/06/09 19:14:46 Done.
+
private:
DISALLOW_COPY_AND_ASSIGN(Demuxer);
};

Powered by Google App Engine
This is Rietveld 408576698