Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: extensions/common/one_shot_event.cc

Issue 204983020: Remove ExtensionService Garbage-Collecting methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/one_shot_event.cc
diff --git a/extensions/common/one_shot_event.cc b/extensions/common/one_shot_event.cc
index 28f91cb2060255693a358d4757ff1e884412a2cc..3e9c2158049a746fcaf7ff6100ce388cb0c7af19 100644
--- a/extensions/common/one_shot_event.cc
+++ b/extensions/common/one_shot_event.cc
@@ -5,25 +5,35 @@
#include "extensions/common/one_shot_event.h"
#include "base/callback.h"
+#include "base/lazy_instance.h"
#include "base/location.h"
#include "base/message_loop/message_loop_proxy.h"
#include "base/task_runner.h"
+#include "base/time/time.h"
using base::TaskRunner;
namespace extensions {
+namespace {
+
+base::LazyInstance<base::TimeDelta> g_empty_delta = LAZY_INSTANCE_INITIALIZER;
+
+} // namespace
+
struct OneShotEvent::TaskInfo {
TaskInfo() {}
TaskInfo(const tracked_objects::Location& from_here,
const scoped_refptr<TaskRunner>& runner,
- const base::Closure& task)
- : from_here(from_here), runner(runner), task(task) {
+ const base::Closure& task,
+ const base::TimeDelta& delay)
+ : from_here(from_here), runner(runner), task(task), delay(delay) {
CHECK(runner.get()); // Detect mistakes with a decent stack frame.
}
tracked_objects::Location from_here;
scoped_refptr<TaskRunner> runner;
base::Closure task;
+ base::TimeDelta delay;
};
OneShotEvent::OneShotEvent() : signaled_(false) {
@@ -38,19 +48,20 @@ OneShotEvent::~OneShotEvent() {}
void OneShotEvent::Post(const tracked_objects::Location& from_here,
const base::Closure& task) const {
- Post(from_here, task, base::MessageLoopProxy::current());
+ PostImpl(
+ from_here, task, base::MessageLoopProxy::current(), g_empty_delta.Get());
}
void OneShotEvent::Post(const tracked_objects::Location& from_here,
const base::Closure& task,
const scoped_refptr<TaskRunner>& runner) const {
- DCHECK(thread_checker_.CalledOnValidThread());
+ PostImpl(from_here, task, runner, g_empty_delta.Get());
+}
- if (is_signaled()) {
- runner->PostTask(from_here, task);
- } else {
- tasks_.push_back(TaskInfo(from_here, runner, task));
- }
+void OneShotEvent::PostDelayed(const tracked_objects::Location& from_here,
+ const base::Closure& task,
+ const base::TimeDelta& delay) const {
+ PostImpl(from_here, task, base::MessageLoopProxy::current(), delay);
}
void OneShotEvent::Signal() {
@@ -66,7 +77,27 @@ void OneShotEvent::Signal() {
// We could randomize tasks_ in debug mode in order to check that
// the order doesn't matter...
for (size_t i = 0; i < tasks_.size(); ++i) {
- tasks_[i].runner->PostTask(tasks_[i].from_here, tasks_[i].task);
+ const TaskInfo& task = tasks_[i];
+ if (task.delay != g_empty_delta.Get())
+ task.runner->PostDelayedTask(task.from_here, task.task, task.delay);
+ else
+ task.runner->PostTask(task.from_here, task.task);
+ }
+}
+
+void OneShotEvent::PostImpl(const tracked_objects::Location& from_here,
+ const base::Closure& task,
+ const scoped_refptr<TaskRunner>& runner,
+ const base::TimeDelta& delay) const {
+ DCHECK(thread_checker_.CalledOnValidThread());
+
+ if (is_signaled()) {
+ if (delay != g_empty_delta.Get())
+ runner->PostDelayedTask(from_here, task, delay);
+ else
+ runner->PostTask(from_here, task);
+ } else {
+ tasks_.push_back(TaskInfo(from_here, runner, task, delay));
}
}

Powered by Google App Engine
This is Rietveld 408576698