Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Side by Side Diff: chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc

Issue 204983020: Remove ExtensionService Garbage-Collecting methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.h" 5 #include "chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.h"
6 6
7 #include "ash/screensaver/screensaver_view.h" 7 #include "ash/screensaver/screensaver_view.h"
8 #include "ash/shell.h" 8 #include "ash/shell.h"
9 #include "ash/wm/user_activity_detector.h" 9 #include "ash/wm/user_activity_detector.h"
10 #include "base/bind.h" 10 #include "base/bind.h"
11 #include "base/callback.h" 11 #include "base/callback.h"
12 #include "base/lazy_instance.h" 12 #include "base/lazy_instance.h"
13 #include "base/logging.h" 13 #include "base/logging.h"
14 #include "chrome/browser/browser_process.h" 14 #include "chrome/browser/browser_process.h"
15 #include "chrome/browser/chrome_notification_types.h" 15 #include "chrome/browser/chrome_notification_types.h"
16 #include "chrome/browser/chromeos/kiosk_mode/kiosk_mode_settings.h" 16 #include "chrome/browser/chromeos/kiosk_mode/kiosk_mode_settings.h"
17 #include "chrome/browser/chromeos/login/existing_user_controller.h" 17 #include "chrome/browser/chromeos/login/existing_user_controller.h"
18 #include "chrome/browser/chromeos/login/login_display_host_impl.h" 18 #include "chrome/browser/chromeos/login/login_display_host_impl.h"
19 #include "chrome/browser/chromeos/policy/app_pack_updater.h" 19 #include "chrome/browser/chromeos/policy/app_pack_updater.h"
20 #include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h" 20 #include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"
21 #include "chrome/browser/chromeos/profiles/profile_helper.h" 21 #include "chrome/browser/chromeos/profiles/profile_helper.h"
22 #include "chrome/browser/extensions/extension_garbage_collector.h"
22 #include "chrome/browser/extensions/extension_service.h" 23 #include "chrome/browser/extensions/extension_service.h"
23 #include "chrome/browser/extensions/sandboxed_unpacker.h" 24 #include "chrome/browser/extensions/sandboxed_unpacker.h"
24 #include "chrome/browser/ui/webui/chromeos/login/oobe_ui.h" 25 #include "chrome/browser/ui/webui/chromeos/login/oobe_ui.h"
25 #include "chrome/common/extensions/extension_file_util.h" 26 #include "chrome/common/extensions/extension_file_util.h"
26 #include "chrome/common/extensions/manifest_handlers/app_launch_info.h" 27 #include "chrome/common/extensions/manifest_handlers/app_launch_info.h"
27 #include "chromeos/login/login_state.h" 28 #include "chromeos/login/login_state.h"
28 #include "content/public/browser/browser_thread.h" 29 #include "content/public/browser/browser_thread.h"
29 #include "content/public/browser/notification_service.h" 30 #include "content/public/browser/notification_service.h"
30 #include "extensions/browser/extension_system.h" 31 #include "extensions/browser/extension_system.h"
31 #include "extensions/common/extension.h" 32 #include "extensions/common/extension.h"
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 103
103 void ScreensaverUnpackerClient::LoadScreensaverExtension( 104 void ScreensaverUnpackerClient::LoadScreensaverExtension(
104 const base::FilePath& extension_base_path, 105 const base::FilePath& extension_base_path,
105 const base::FilePath& screensaver_extension_path) { 106 const base::FilePath& screensaver_extension_path) {
106 DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE)); 107 DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE));
107 108
108 ExtensionService* service = GetDefaultExtensionService(); 109 ExtensionService* service = GetDefaultExtensionService();
109 // TODO(rkc): This is a HACK, please remove this method from extension 110 // TODO(rkc): This is a HACK, please remove this method from extension
110 // service once this code is deprecated. See crbug.com/280363 111 // service once this code is deprecated. See crbug.com/280363
111 if (service) 112 if (service)
112 service->disable_garbage_collection(); 113 service->garbage_collector()->disable_garbage_collection();
113 114
114 std::string error; 115 std::string error;
115 scoped_refptr<Extension> screensaver_extension = 116 scoped_refptr<Extension> screensaver_extension =
116 extension_file_util::LoadExtension(screensaver_extension_path, 117 extension_file_util::LoadExtension(screensaver_extension_path,
117 extensions::Manifest::COMPONENT, 118 extensions::Manifest::COMPONENT,
118 Extension::NO_FLAGS, 119 Extension::NO_FLAGS,
119 &error); 120 &error);
120 if (!screensaver_extension.get()) { 121 if (!screensaver_extension.get()) {
121 LOG(ERROR) << "Could not load screensaver extension from: " 122 LOG(ERROR) << "Could not load screensaver extension from: "
122 << screensaver_extension_path.value() << " due to: " << error; 123 << screensaver_extension_path.value() << " due to: " << error;
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 // do anything (see crbug.com/288216). 171 // do anything (see crbug.com/288216).
171 if (!g_browser_process || g_browser_process->IsShuttingDown()) 172 if (!g_browser_process || g_browser_process->IsShuttingDown())
172 return; 173 return;
173 174
174 // If the extension was unpacked. 175 // If the extension was unpacked.
175 if (!extension_base_path_.empty()) { 176 if (!extension_base_path_.empty()) {
176 ExtensionService* service = GetDefaultExtensionService(); 177 ExtensionService* service = GetDefaultExtensionService();
177 // TODO(rkc): This is a HACK, please remove this method from extension 178 // TODO(rkc): This is a HACK, please remove this method from extension
178 // service once this code is deprecated. See crbug.com/280363 179 // service once this code is deprecated. See crbug.com/280363
179 if (service) 180 if (service)
180 service->enable_garbage_collection(); 181 service->garbage_collector()->enable_garbage_collection();
181 182
182 // Delete it. 183 // Delete it.
183 content::BrowserThread::PostTask( 184 content::BrowserThread::PostTask(
184 content::BrowserThread::FILE, 185 content::BrowserThread::FILE,
185 FROM_HERE, 186 FROM_HERE,
186 base::Bind( 187 base::Bind(
187 &extension_file_util::DeleteFile, extension_base_path_, true)); 188 &extension_file_util::DeleteFile, extension_base_path_, true));
188 } 189 }
189 190
190 // In case we're shutting down without ever triggering the active 191 // In case we're shutting down without ever triggering the active
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
299 300
300 g_kiosk_mode_screensaver = new KioskModeScreensaver(); 301 g_kiosk_mode_screensaver = new KioskModeScreensaver();
301 } 302 }
302 303
303 void ShutdownKioskModeScreensaver() { 304 void ShutdownKioskModeScreensaver() {
304 delete g_kiosk_mode_screensaver; 305 delete g_kiosk_mode_screensaver;
305 g_kiosk_mode_screensaver = NULL; 306 g_kiosk_mode_screensaver = NULL;
306 } 307 }
307 308
308 } // namespace chromeos 309 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698