Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 20496002: WebCrypto: Add parameter normalization for HMAC. (Closed)

Created:
7 years, 5 months ago by eroman
Modified:
7 years, 5 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, Nils Barth (inactive), jamesr, kojih, jsbell+bindings_chromium.org, eae+blinkwatch, tommyw+watchlist_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, haraken, Nate Chapin, jeez, do-not-use
Visibility:
Public.

Description

WebCrypto: Add parameter normalization for HMAC. BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154963

Patch Set 1 #

Patch Set 2 : clarify a comment #

Patch Set 3 : rebase onto master #

Patch Set 4 : add test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -14 lines) Patch
M LayoutTests/crypto/normalize-algorithm.html View 2 chunks +20 lines, -0 lines 0 comments Download
M LayoutTests/crypto/normalize-algorithm-expected.txt View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M Source/bindings/v8/custom/V8AlgorithmCustom.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/platform/chromium/support/WebCryptoAlgorithm.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/modules/crypto/Algorithm.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
A + Source/modules/crypto/HmacParams.h View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
A + Source/modules/crypto/HmacParams.cpp View 1 chunk +6 lines, -4 lines 0 comments Download
A + Source/modules/crypto/HmacParams.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/crypto/NormalizeAlgorithm.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/crypto/NormalizeAlgorithm.cpp View 1 4 chunks +24 lines, -0 lines 0 comments Download
M Source/modules/modules.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M public/platform/WebCryptoAlgorithm.h View 3 chunks +4 lines, -0 lines 0 comments Download
M public/platform/WebCryptoAlgorithmParams.h View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
eroman
7 years, 5 months ago (2013-07-25 21:07:33 UTC) #1
abarth-chromium
lgtm
7 years, 5 months ago (2013-07-25 21:21:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/20496002/6001
7 years, 5 months ago (2013-07-25 21:45:53 UTC) #3
eroman
Had forgotten to add the updated test expectations, fixed.
7 years, 5 months ago (2013-07-25 21:53:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/20496002/6002
7 years, 5 months ago (2013-07-25 22:07:40 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-26 02:32:49 UTC) #6
Message was sent while issue was closed.
Change committed as 154963

Powered by Google App Engine
This is Rietveld 408576698