Refactor multiarg, split MGS/PLS.

service/datastore/pls_test.go

 // Copyright 2015 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 // adapted from github.com/golang/appengine/datastore
 
 package datastore
 
 import (
         "bytes"
@@ skipping 1795 matching lines @@
                 Convey("multiple overlapping fields is an error", func() {
                         o := &BadMeta{}
                         So(func() { GetPLS(o) }, ShouldPanicLike, "multiple times")
                 })
 
                 Convey("empty property names are invalid", func() {
                         So(validPropertyName(""), ShouldBeFalse)
                 })
 
                 Convey("attempting to get a PLS for a non *struct is an error", func() {
-                        So(func() { GetPLS((*[]string)(nil)) }, ShouldPanicLike,
+                        s := []string{}
+                        So(func() { GetPLS(&s) }, ShouldPanicLike,
                                 "cannot GetPLS(*[]string): not a pointer-to-struct")
                 })
 
+                Convey("attempting to get a PLS for a nil pointer-to-struct is an error", func() {
+                        var s *Simple
+                        So(func() { GetPLS(s) }, ShouldPanicLike,
+                                "cannot GetPLS(*datastore.Simple): pointer is nil")
+                })
+
                 Convey("convertible meta default types", func() {
                         type OKDefaults struct {
                                 When   string `gae:"$when,tomorrow"`
                                 Amount int64  `gae:"$amt,100"`
                                 DoIt   Toggle `gae:"$doit,on"`
                         }
                         okd := &OKDefaults{}
                         mgs := getMGS(okd)
 
                         v, ok := mgs.GetMeta("when")
@@ skipping 193 matching lines @@
                         So(pls.SetMeta("id", "sup|1337"), ShouldBeTrue)
                         So(ide.EmbeddedID, ShouldResemble, EmbeddedID{"sup", 1337})
 
                         So(pls.GetAllMeta(), ShouldResemble, PropertyMap{
                                 "$id":   {mpNI("sup|1337")},
                                 "$kind": {mpNI("IDEmbedder")},
                         })
                 })
         })
 }