Remove DeferredImageDecoder::setEnabled and ImageDecoder::deferredImageDecodingEnabled

Remove DeferredImageDecoder::setEnabled and ImageDecoder::deferredImageDecodingEnabled

DeferredImageDecoder::setEnabled is used only at BitmapImageTest and not
used in non-test code. ImageDecoder::deferredImageDecodingEnabled is not
called anywhere. This CL removes those functions for code health.

BUG=n/a
TEST=blink_platform_unittests --gtest_filter=BitmapImageTest.*:ImageDecoderTest.* ; webkit_unit_tests --gtest_filter=DeferredImageDecoderTest.*

Committed: https://crrev.com/92830b03fe331909624a8e095d739f6bab9752a9
Cr-Commit-Position: refs/heads/master@{#399128}

[hajimehoshi, 2016-06-08 10:51:49]

hajimehoshi@chromium.org changed reviewers:
+ schenney@chromium.org

[hajimehoshi, 2016-06-08 10:51:49]

PTAL

[hajimehoshi, 2016-06-08 10:56:37]

Description was changed from

==========
Remove DeferredImageDecoder::setEnabled and
ImageDecoder::deferredImageDecodingEnabled

DeferredImageDecoder::setEnabled is used only at BitmapImageTest and not
used in non-test code. ImageDecoder::deferredImageDecodingEnabled is not
called anywhere. This CL removes those functions for code health.

BUG=n/a
TEST=blink_platform_unittests --gtest_filter=BitmapImageTest.*,
ImageDecoderTest.*
==========

to

==========
Remove DeferredImageDecoder::setEnabled and
ImageDecoder::deferredImageDecodingEnabled

DeferredImageDecoder::setEnabled is used only at BitmapImageTest and not
used in non-test code. ImageDecoder::deferredImageDecodingEnabled is not
called anywhere. This CL removes those functions for code health.

BUG=n/a
TEST=blink_platform_unittests --gtest_filter=BitmapImageTest.*,
ImageDecoderTest.*
==========

[hajimehoshi, 2016-06-08 10:56:37]

hajimehoshi@chromium.org changed reviewers:
+ noel@chromium.org

[hajimehoshi, 2016-06-08 10:57:23]

+noel

[hajimehoshi, 2016-06-08 10:59:01]

Description was changed from

==========
Remove DeferredImageDecoder::setEnabled and
ImageDecoder::deferredImageDecodingEnabled

DeferredImageDecoder::setEnabled is used only at BitmapImageTest and not
used in non-test code. ImageDecoder::deferredImageDecodingEnabled is not
called anywhere. This CL removes those functions for code health.

BUG=n/a
TEST=blink_platform_unittests --gtest_filter=BitmapImageTest.*,
ImageDecoderTest.*
==========

to

==========
Remove DeferredImageDecoder::setEnabled and
ImageDecoder::deferredImageDecodingEnabled

DeferredImageDecoder::setEnabled is used only at BitmapImageTest and not
used in non-test code. ImageDecoder::deferredImageDecodingEnabled is not
called anywhere. This CL removes those functions for code health.

BUG=n/a
TEST=blink_platform_unittests
--gtest_filter=BitmapImageTest.*:ImageDecoderTest.* ; webkit_unit_tests
--gtest_filter=DeferredImageDecoderTest.*
==========

[chrishtr, 2016-06-08 20:02:12]

chrishtr@chromium.org changed reviewers:
+ chrishtr@chromium.org

[chrishtr, 2016-06-08 20:02:13]

https://codereview.chromium.org/2048003002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp (left):

https://codereview.chromium.org/2048003002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp:269:
EXPECT_EQ(frameSize * 2, lastDecodedSizeChange());
Why did this change?

[hajimehoshi, 2016-06-09 04:02:38]

https://codereview.chromium.org/2048003002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp (left):

https://codereview.chromium.org/2048003002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp:269:
EXPECT_EQ(frameSize * 2, lastDecodedSizeChange());
On 2016/06/08 20:02:12, chrishtr wrote:
> Why did this change?

It's because the original test assumed that
DeferredImageDecoder::setEnabled(false), which I'm trying to remove. This now
equals to BitmapImageDeferredDecodingTest.correctDecodedDataSize in the original
code.

[chrishtr, 2016-06-09 04:10:20]

lgtm

[hajimehoshi, 2016-06-09 05:01:06]

The CQ bit was checked by hajimehoshi@chromium.org

[hajimehoshi, 2016-06-09 05:01:23]

The CQ bit was unchecked by hajimehoshi@chromium.org

[hajimehoshi, 2016-06-09 05:02:57]

hajimehoshi@chromium.org changed reviewers:
+ pkasting@google.com

[hajimehoshi, 2016-06-09 05:03:34]

On 2016/06/09 04:10:20, chrishtr wrote:
> lgtm

Thanks.

+pkasting PTAL at image-decoders dir

[Peter Kasting, 2016-06-10 00:16:56]

pkasting@chromium.org changed reviewers:
+ pkasting@chromium.org

[Peter Kasting, 2016-06-10 00:16:57]

LGTM

[hajimehoshi, 2016-06-10 03:24:56]

The CQ bit was checked by hajimehoshi@chromium.org

[commit-bot: I haz the power, 2016-06-10 03:25:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2048003002/40001

[commit-bot: I haz the power, 2016-06-10 04:27:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-10 04:27:49]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[hajimehoshi, 2016-06-10 05:06:34]

The CQ bit was checked by hajimehoshi@chromium.org

[commit-bot: I haz the power, 2016-06-10 05:06:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2048003002/40001

[commit-bot: I haz the power, 2016-06-10 06:56:36]

Description was changed from

==========
Remove DeferredImageDecoder::setEnabled and
ImageDecoder::deferredImageDecodingEnabled

DeferredImageDecoder::setEnabled is used only at BitmapImageTest and not
used in non-test code. ImageDecoder::deferredImageDecodingEnabled is not
called anywhere. This CL removes those functions for code health.

BUG=n/a
TEST=blink_platform_unittests
--gtest_filter=BitmapImageTest.*:ImageDecoderTest.* ; webkit_unit_tests
--gtest_filter=DeferredImageDecoderTest.*
==========

to

==========
Remove DeferredImageDecoder::setEnabled and
ImageDecoder::deferredImageDecodingEnabled

DeferredImageDecoder::setEnabled is used only at BitmapImageTest and not
used in non-test code. ImageDecoder::deferredImageDecodingEnabled is not
called anywhere. This CL removes those functions for code health.

BUG=n/a
TEST=blink_platform_unittests
--gtest_filter=BitmapImageTest.*:ImageDecoderTest.* ; webkit_unit_tests
--gtest_filter=DeferredImageDecoderTest.*
==========

[commit-bot: I haz the power, 2016-06-10 06:56:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-10 06:56:39]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-10 06:59:19]

Description was changed from

==========
Remove DeferredImageDecoder::setEnabled and
ImageDecoder::deferredImageDecodingEnabled

DeferredImageDecoder::setEnabled is used only at BitmapImageTest and not
used in non-test code. ImageDecoder::deferredImageDecodingEnabled is not
called anywhere. This CL removes those functions for code health.

BUG=n/a
TEST=blink_platform_unittests
--gtest_filter=BitmapImageTest.*:ImageDecoderTest.* ; webkit_unit_tests
--gtest_filter=DeferredImageDecoderTest.*
==========

to

==========
Remove DeferredImageDecoder::setEnabled and
ImageDecoder::deferredImageDecodingEnabled

DeferredImageDecoder::setEnabled is used only at BitmapImageTest and not
used in non-test code. ImageDecoder::deferredImageDecodingEnabled is not
called anywhere. This CL removes those functions for code health.

BUG=n/a
TEST=blink_platform_unittests
--gtest_filter=BitmapImageTest.*:ImageDecoderTest.* ; webkit_unit_tests
--gtest_filter=DeferredImageDecoderTest.*

Committed: https://crrev.com/92830b03fe331909624a8e095d739f6bab9752a9
Cr-Commit-Position: refs/heads/master@{#399128}
==========

[commit-bot: I haz the power, 2016-06-10 06:59:21]

Patchset 3 (id:??) landed as
https://crrev.com/92830b03fe331909624a8e095d739f6bab9752a9
Cr-Commit-Position: refs/heads/master@{#399128}