Issue 20475004: WebCrypto: Properly normalize algorithm for importKey().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20475004: WebCrypto: Properly normalize algorithm for importKey(). (Closed)

Created:
7 years, 4 months ago by eroman

Modified:
7 years, 4 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

WebCrypto: Properly normalize algorithm for importKey(). HMAC should retain the "hash" parameters after normalization. This corresponds with the spec update: https://dvcs.w3.org/hg/webcrypto-api/rev/5cf8db70af2e BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155297

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -32 lines)			Patch
M	LayoutTests/crypto/importKey.html	View	13 chunks	+25 lines, -14 lines	0 comments	Download
M	LayoutTests/crypto/importKey-expected.txt	View	2 chunks	+8 lines, -5 lines	0 comments	Download
M	LayoutTests/crypto/normalize-algorithm.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/crypto/NormalizeAlgorithm.h	View	2 chunks	+1 line, -1 line	0 comments	Download
M	Source/modules/crypto/NormalizeAlgorithm.cpp	View	2 chunks	+2 lines, -10 lines	0 comments	Download
M	Source/modules/crypto/SubtleCrypto.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/20475004/1

7 years, 4 months ago (2013-07-31 22:51:58 UTC) #3

Message was sent while issue was closed.

Change committed as 155297