Issue 20466002: Enable HiDPI assets for the WebUI in iOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20466002: Enable HiDPI assets for the WebUI in iOS. (Closed)

Created:
7 years, 5 months ago by Justin Cohen (wrong one)

Modified:
7 years, 4 months ago

Reviewers:
stuartmorgan, Nico, justincohen

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Enable HiDPI assets for the WebUI in iOS. Change common.gypi to pass scale_factors=2x to grit on iOS. BUG=262913 TEST=WebUI assets show as 2x on iOS. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214578

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/common.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

stuartmorgan

LGTM (Seems confusing that 1x isn't listed, but that's not this CL's fault)

7 years, 4 months ago (2013-07-30 18:29:59 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@google.com/20466002/1

7 years, 4 months ago (2013-07-30 20:47:41 UTC) #4

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=181701

7 years, 4 months ago (2013-07-31 03:04:44 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@google.com/20466002/1

7 years, 4 months ago (2013-07-31 03:18:51 UTC) #6

Message was sent while issue was closed.

Change committed as 214578

Expand Messages | Collapse Messages