[Payments] Add ability to show additional text for OptionSections

[Payments] Add ability to show additional text for OptionSections

* Add ability to display additional text above the PaymentOption
  lists.

* Shipping address section now has the option to display text
  saying that the user needs to select a shipping address to
  update the shipping options.

* Optional shipping address section text disappears once the
  user selects an option.

BUG=603635
Committed: https://crrev.com/b060edf6cd3e098f96806f4d09717bfd6caaa374
Cr-Commit-Position: refs/heads/master@{#397900}

[gone, 2016-06-03 23:09:53]

dfalcantara@chromium.org changed reviewers:
+ rouslan@chromium.org

[gone, 2016-06-03 23:09:54]

Rouslan: do these changes seem sane to you?

https://codereview.chromium.org/2040623002/diff/1/chrome/android/java/res/val...
File chrome/android/java/res/values-v17/styles.xml (right):

https://codereview.chromium.org/2040623002/diff/1/chrome/android/java/res/val...
chrome/android/java/res/values-v17/styles.xml:462: <style
name="PaymentsUiSectionDescriptiveTextEndAligned"
parent="PaymentsUiSectionDescriptiveText">
Doesn't seem to be a line length enforced in this file.

[please use gerrit instead, 2016-06-03 23:21:23]

Thank you for the quick turn around!

lgtm % minor comments.

https://codereview.chromium.org/2040623002/diff/1/chrome/android/java/res/val...
File chrome/android/java/res/values-v17/styles.xml (right):

https://codereview.chromium.org/2040623002/diff/1/chrome/android/java/res/val...
chrome/android/java/res/values-v17/styles.xml:462: <style
name="PaymentsUiSectionDescriptiveTextEndAligned"
parent="PaymentsUiSectionDescriptiveText">
On 2016/06/03 23:09:54, dfalcantara wrote:
> Doesn't seem to be a line length enforced in this file.

You're safe.

https://codereview.chromium.org/2040623002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
(right):

https://codereview.chromium.org/2040623002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java:123:
* Checks if the merchant needs a shipping address for the order.
Checks if the merchant needs a shipping address to provide the shipping options.

https://codereview.chromium.org/2040623002/diff/1/chrome/android/java/strings...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/2040623002/diff/1/chrome/android/java/strings...
chrome/android/java/strings/android_chrome_strings.grd:2435: <message
name="IDS_PAYMENTS_SELECT_SHIPPING_ADDRESS_FOR_SHIPPING_METHODS" desc="Text
implying that they need to pick a shipping address to see the shipping
methods.">
s/they need/a user needs/

[gone, 2016-06-03 23:37:17]

https://codereview.chromium.org/2040623002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
(right):

https://codereview.chromium.org/2040623002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java:123:
* Checks if the merchant needs a shipping address for the order.
On 2016/06/03 23:21:22, Rouslan (ツ) wrote:
> Checks if the merchant needs a shipping address to provide the shipping
options.

Done.

https://codereview.chromium.org/2040623002/diff/1/chrome/android/java/strings...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/2040623002/diff/1/chrome/android/java/strings...
chrome/android/java/strings/android_chrome_strings.grd:2435: <message
name="IDS_PAYMENTS_SELECT_SHIPPING_ADDRESS_FOR_SHIPPING_METHODS" desc="Text
implying that they need to pick a shipping address to see the shipping
methods.">
On 2016/06/03 23:21:23, Rouslan (ツ) wrote:
> s/they need/a user needs/

Done.

[gone, 2016-06-04 02:57:51]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2016-06-04 02:57:51]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/2040623002/#ps20001
(title: "Comments")

[commit-bot: I haz the power, 2016-06-04 02:58:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2040623002/20001

[commit-bot: I haz the power, 2016-06-04 03:49:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-04 03:51:29]

Description was changed from

==========
[Payments] Add ability to show additional text for OptionSections

* Add ability to display additional text above the PaymentOption
  lists.

* Shipping address section now has the option to display text
  saying that the user needs to select a shipping address to
  update the shipping options.

* Optional shipping address section text disappears once the
  user selects an option.

BUG=603635
==========

to

==========
[Payments] Add ability to show additional text for OptionSections

* Add ability to display additional text above the PaymentOption
  lists.

* Shipping address section now has the option to display text
  saying that the user needs to select a shipping address to
  update the shipping options.

* Optional shipping address section text disappears once the
  user selects an option.

BUG=603635

Committed: https://crrev.com/b060edf6cd3e098f96806f4d09717bfd6caaa374
Cr-Commit-Position: refs/heads/master@{#397900}
==========

[commit-bot: I haz the power, 2016-06-04 03:51:30]

Patchset 2 (id:??) landed as
https://crrev.com/b060edf6cd3e098f96806f4d09717bfd6caaa374
Cr-Commit-Position: refs/heads/master@{#397900}