Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 20399002: Add a tool for clearing the system cache for a directory. (Closed)

Created:
7 years, 5 months ago by James Simonsen
Modified:
7 years, 5 months ago
Reviewers:
tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com
Visibility:
Public.

Description

Add a tool for clearing the system cache for a directory. This is a wrapper around existing functionality in base/test/test_file_util.h. This will be used in the cold startup Telemetry tests. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213941

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -9 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A + tools/perf/clear_system_cache/clear_system_cache.gyp View 1 1 chunk +7 lines, -9 lines 0 comments Download
A tools/perf/clear_system_cache/clear_system_cache_main.cc View 1 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
James Simonsen
7 years, 5 months ago (2013-07-25 18:20:46 UTC) #1
tonyg
lgtm https://codereview.chromium.org/20399002/diff/1/tools/perf/clear_system_cache/clear_system_cache.cc File tools/perf/clear_system_cache/clear_system_cache.cc (right): https://codereview.chromium.org/20399002/diff/1/tools/perf/clear_system_cache/clear_system_cache.cc#newcode39 tools/perf/clear_system_cache/clear_system_cache.cc:39: continue; Just a thought, but should we make ...
7 years, 5 months ago (2013-07-25 21:30:42 UTC) #2
dtu
This is another candidate for things that get zipped up into Cloud Storage.
7 years, 5 months ago (2013-07-25 22:34:39 UTC) #3
James Simonsen
https://codereview.chromium.org/20399002/diff/1/tools/perf/clear_system_cache/clear_system_cache.cc File tools/perf/clear_system_cache/clear_system_cache.cc (right): https://codereview.chromium.org/20399002/diff/1/tools/perf/clear_system_cache/clear_system_cache.cc#newcode39 tools/perf/clear_system_cache/clear_system_cache.cc:39: continue; On 2013/07/25 21:30:42, tonyg wrote: > Just a ...
7 years, 5 months ago (2013-07-26 02:14:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonjam@chromium.org/20399002/7001
7 years, 5 months ago (2013-07-26 04:06:17 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-26 17:05:46 UTC) #6
Message was sent while issue was closed.
Change committed as 213941

Powered by Google App Engine
This is Rietveld 408576698