Use ContextUtils#getApplicationContext() instead of passing Context to ShortcutHelper

chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser;
 
 import android.app.ActivityManager;
 import android.content.Context;
 import android.content.Intent;
 import android.content.pm.PackageManager;
@@ skipping 119 matching lines @@
     /**
      * Called when we have to fire an Intent to add a shortcut to the home screen.
      * If the webpage indicated that it was capable of functioning as a webapp, it is added as a
      * shortcut to a webapp Activity rather than as a general bookmark. User is sent to the
      * home screen as soon as the shortcut is created.
      *
      * This method must not be called on the UI thread.
      */
     @SuppressWarnings("unused")
     @CalledByNative
-    private static void addShortcut(Context context, String id, String url, final String userTitle,
+    private static void addShortcut(String id, String url, final String userTitle,
             String name, String shortName, Bitmap icon, int displayMode, int orientation,
             int source, long themeColor, long backgroundColor, boolean isIconGenerated,
             final long callbackPointer) {
         assert !ThreadUtils.runningOnUiThread();
+
+        Context context = ContextUtils.getApplicationContext();
         final Intent shortcutIntent;
         boolean isWebappCapable = (displayMode == WebDisplayMode.Standalone
                                 || displayMode == WebDisplayMode.Fullscreen);
         if (isWebappCapable) {
             shortcutIntent = createWebappShortcutIntent(id, sDelegate.getFullscreenAction(), url,
                     getScopeFromUrl(url), name, shortName, icon, WEBAPP_SHORTCUT_VERSION,
                     displayMode, orientation, themeColor, backgroundColor, isIconGenerated);
             shortcutIntent.putExtra(EXTRA_MAC, getEncodedMac(context, url));
         } else {
             // Add the shortcut as a launcher icon to open in the browser Activity.
@@ skipping 30 matching lines @@
                 String toastText =
                         applicationContext.getString(R.string.added_to_homescreen, userTitle);
                 Toast toast = Toast.makeText(applicationContext, toastText, Toast.LENGTH_SHORT);
                 toast.show();
             }
         });
     }
 
     /**
      * Creates a storage location and stores the data for a web app using {@link WebappDataStorage}.
-     * @param context     Context to open the WebappDataStorage with.
      * @param id          ID of the webapp which is storing data.
      * @param splashImage Image which should be displayed on the splash screen of
      *                    the webapp. This can be null of there is no image to show.
      */
     @SuppressWarnings("unused")
     @CalledByNative
-    private static void storeWebappSplashImage(final Context context, final String id,
-            final Bitmap splashImage) {
-        WebappRegistry.getWebappDataStorage(context, id,
+    private static void storeWebappSplashImage(final String id, final Bitmap splashImage) {
+        WebappRegistry.getWebappDataStorage(ContextUtils.getApplicationContext(), id,
                 new WebappRegistry.FetchWebappDataStorageCallback() {
                     @Override
                     public void onWebappDataStorageRetrieved(WebappDataStorage storage) {
                         if (storage == null) return;
 
                         storage.updateSplashScreenImage(splashImage);
                     }
 
-                }
-        );
+                });
     }
 
     /**
      * Creates an intent that will add a shortcut to the home screen.
      * @param shortcutIntent Intent to fire when the shortcut is activated.
      * @param url URL of the shortcut.
      * @param title Title of the shortcut.
      * @param icon Image that represents the shortcut.
      * @return Intent for the shortcut.
      */
@@ skipping 78 matching lines @@
     public static boolean isAddToHomeIntentSupported(Context context) {
         PackageManager pm = context.getPackageManager();
         Intent i = new Intent(INSTALL_SHORTCUT);
         List<ResolveInfo> receivers = pm.queryBroadcastReceivers(
                 i, PackageManager.GET_INTENT_FILTERS);
         return !receivers.isEmpty();
     }
 
     /**
      * Returns whether the given icon matches the size requirements to be used on the home screen.
-     * @param context Context used to create the intent.
      * @param width Icon width, in pixels.
      * @param height Icon height, in pixels.
      * @return whether the given icon matches the size requirements to be used on the home screen.
      */
     @CalledByNative
-    public static boolean isIconLargeEnoughForLauncher(Context context, int width, int height) {
+    public static boolean isIconLargeEnoughForLauncher(int width, int height) {
+        Context context = ContextUtils.getApplicationContext();
         ActivityManager am = (ActivityManager) context.getSystemService(Context.ACTIVITY_SERVICE);
         final int minimalSize = am.getLauncherLargeIconSize() / 2;
         return width >= minimalSize && height >= minimalSize;
     }
 
     /**
      * Adapts a website's icon (e.g. favicon or touch icon) to the Material design style guidelines
      * for home screen icons. This involves adding some padding and rounding the corners.
      *
      * @param context Context used to create the intent.
      * @param webIcon The website's favicon or touch icon.
      * @return Bitmap Either the touch-icon or the newly created favicon.
      */
     @CalledByNative
-    public static Bitmap createHomeScreenIconFromWebIcon(Context context, Bitmap webIcon) {
+    public static Bitmap createHomeScreenIconFromWebIcon(Bitmap webIcon) {
         // getLauncherLargeIconSize() is just a guess at the launcher icon size, and is often
         // wrong -- the launcher can show icons at any size it pleases. Instead of resizing the
         // icon to the supposed launcher size and then having the launcher resize the icon again,
         // just leave the icon at its original size and let the launcher do a single rescaling.
         // Unless the icon is much too big; then scale it down here too.
+        Context context = ContextUtils.getApplicationContext();
         ActivityManager am = (ActivityManager) context.getSystemService(Context.ACTIVITY_SERVICE);
         int maxInnerSize = Math.round(am.getLauncherLargeIconSize() * MAX_INNER_SIZE_RATIO);
         int innerSize = Math.min(maxInnerSize, Math.max(webIcon.getWidth(), webIcon.getHeight()));
         int padding = Math.round(ICON_PADDING_RATIO * innerSize);
         int outerSize = innerSize + 2 * padding;
 
         Bitmap bitmap = null;
         try {
             bitmap = Bitmap.createBitmap(outerSize, outerSize, Bitmap.Config.ARGB_8888);
         } catch (OutOfMemoryError e) {
@@ skipping 17 matching lines @@
         paint.setXfermode(new PorterDuffXfermode(PorterDuff.Mode.CLEAR));
         canvas.drawPath(path, paint);
 
         return bitmap;
     }
 
     /**
      * Generates a generic icon to be used in the launcher. This is just a rounded rectangle with
      * a letter in the middle taken from the website's domain name.
      *
-     * @param context Context used to create the intent.
      * @param url URL of the shortcut.
      * @param red Red component of the dominant icon color.
      * @param green Green component of the dominant icon color.
      * @param blue Blue component of the dominant icon color.
      * @return Bitmap Either the touch-icon or the newly created favicon.
      */
     @CalledByNative
-    public static Bitmap generateHomeScreenIcon(Context context, String url, int red, int green,
+    public static Bitmap generateHomeScreenIcon(String url, int red, int green,
             int blue) {

[gone, 2016/06/06 18:13:14]

fix indentation.  int blue fits above now.

+        Context context = ContextUtils.getApplicationContext();
         ActivityManager am = (ActivityManager) context.getSystemService(Context.ACTIVITY_SERVICE);
         final int outerSize = am.getLauncherLargeIconSize();
         final int iconDensity = am.getLauncherLargeIconDensity();
 
         Bitmap bitmap = null;
         try {
             bitmap = Bitmap.createBitmap(outerSize, outerSize, Bitmap.Config.ARGB_8888);
         } catch (OutOfMemoryError e) {
             Log.w(TAG, "OutOfMemoryError while trying to draw bitmap on canvas.");
             return null;
@@ skipping 131 matching lines @@
         builder.fragment("");
         builder.query("");
         return builder.build().toString();
     }
 
     /**
      * Returns an array of sizes which describe the ideal size and minimum size of the Home screen
      * icon and the ideal and minimum sizes of the splash screen image in that order.
      */
     @CalledByNative
-    private static int[] getHomeScreenIconAndSplashImageSizes(Context context) {
+    private static int[] getHomeScreenIconAndSplashImageSizes() {
+        Context context = ContextUtils.getApplicationContext();
         // This ordering must be kept up to date with the C++ ShortcutHelper.
         return new int[] {
             getIdealHomescreenIconSizeInDp(context),
             getMinimumHomescreenIconSizeInDp(context),
             getIdealSplashImageSizeInDp(context),
             getMinimumSplashImageSizeInDp(context)
         };
     }
 
     private static int getIdealSizeFromResourceInDp(Context context, int resource) {
         float sizeInPx = context.getResources().getDimension(resource);
         float density = context.getResources().getDisplayMetrics().density;
         return Math.round(sizeInPx / density);
     }
 
     private static Bitmap getBitmapFromResourceId(Context context, int id, int density) {
         Drawable drawable = ApiCompatibilityUtils.getDrawableForDensity(
                 context.getResources(), id, density);
 
         if (drawable instanceof BitmapDrawable) {
             BitmapDrawable bd = (BitmapDrawable) drawable;
             return bd.getBitmap();
         }
         assert false : "The drawable was not a bitmap drawable as expected";
         return null;
     }
 
     private static native void nativeOnWebappDataStored(long callbackPointer);
 }