Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 203683005: [DevTools] Place modal elements (suggest box, popover) above splitters. (Closed)

Created:
6 years, 9 months ago by dgozman
Modified:
6 years, 9 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[DevTools] Place modal elements (suggest box, popover) above splitters. BUG=353090 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169745

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/devtools/front_end/popover.css View 1 chunk +1 line, -1 line 1 comment Download
M Source/devtools/front_end/textPrompt.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
dgozman
Take a look at this quick fix please.
6 years, 9 months ago (2014-03-19 09:37:15 UTC) #1
vsevik
https://chromiumcodereview.appspot.com/203683005/diff/1/Source/devtools/front_end/popover.css File Source/devtools/front_end/popover.css (left): https://chromiumcodereview.appspot.com/203683005/diff/1/Source/devtools/front_end/popover.css#oldcode5 Source/devtools/front_end/popover.css:5: z-index: 100; I am not sure this is safe. ...
6 years, 9 months ago (2014-03-19 16:27:27 UTC) #2
dgozman
On 2014/03/19 16:27:27, vsevik wrote: > https://chromiumcodereview.appspot.com/203683005/diff/1/Source/devtools/front_end/popover.css > File Source/devtools/front_end/popover.css (left): > > https://chromiumcodereview.appspot.com/203683005/diff/1/Source/devtools/front_end/popover.css#oldcode5 > ...
6 years, 9 months ago (2014-03-21 12:54:43 UTC) #3
vsevik
lgtm
6 years, 9 months ago (2014-03-21 15:03:51 UTC) #4
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 9 months ago (2014-03-21 15:08:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/203683005/1
6 years, 9 months ago (2014-03-21 15:08:55 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 15:10:45 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 9 months ago (2014-03-21 15:10:46 UTC) #8
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 9 months ago (2014-03-21 15:12:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/203683005/1
6 years, 9 months ago (2014-03-21 15:12:46 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 16:20:01 UTC) #11
Message was sent while issue was closed. 
Change committed as 169745

Powered by Google App Engine
This is Rietveld 408576698