Fix a misuse of pragma disable/default in a header file.

Fix a misuse of pragma disable/default in a header file.

This may override the enable/disable of this warning in an other file which include base_helpers.h.

R=ajwong@chromium.org, erikwright@chromium.org
BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214573

[etienneb, 2013-07-25 18:54:35]

PTAL.

[erikwright (departed), 2013-07-26 15:17:56]

LG. Something funky with Rietveld and/or git cl try. Normally you can click the
trybot result indicators to see details but these ones just reload the
codereview page.

https://codereview.chromium.org/20353002/diff/1/base/bind_helpers.h
File base/bind_helpers.h (right):

https://codereview.chromium.org/20353002/diff/1/base/bind_helpers.h#newcode246
base/bind_helpers.h:246: #pragma warning(pop)
One could just pull the push outside of the #if defined and then remove the #if
defined around the pop.

But I'd let Albert indicate which he prefers.

[awong, 2013-07-26 17:50:09]

LGTM

https://codereview.chromium.org/20353002/diff/1/base/bind_helpers.h
File base/bind_helpers.h (right):

https://codereview.chromium.org/20353002/diff/1/base/bind_helpers.h#newcode246
base/bind_helpers.h:246: #pragma warning(pop)
On 2013/07/26 15:17:56, erikwright wrote:
> One could just pull the push outside of the #if defined and then remove the
#if
> defined around the pop.
> 
> But I'd let Albert indicate which he prefers.

I'm confused...don't the pragmas need to be inside the if defined always?

Anyways, looks good as is.

[commit-bot: I haz the power, 2013-07-30 20:46:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/etienneb@chromium.org/20353002/1

[commit-bot: I haz the power, 2013-07-31 05:22:05]

Change committed as 214573