Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 2032773002: [Android] Fix a bug that snackbar does not show when there is no tab on tablet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@snacky_touch
Patch Set: comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser; 5 package org.chromium.chrome.browser;
6 6
7 import android.annotation.SuppressLint; 7 import android.annotation.SuppressLint;
8 import android.annotation.TargetApi; 8 import android.annotation.TargetApi;
9 import android.app.Activity; 9 import android.app.Activity;
10 import android.app.SearchManager; 10 import android.app.SearchManager;
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 import org.chromium.base.VisibleForTesting; 54 import org.chromium.base.VisibleForTesting;
55 import org.chromium.base.metrics.RecordHistogram; 55 import org.chromium.base.metrics.RecordHistogram;
56 import org.chromium.base.metrics.RecordUserAction; 56 import org.chromium.base.metrics.RecordUserAction;
57 import org.chromium.chrome.R; 57 import org.chromium.chrome.R;
58 import org.chromium.chrome.browser.IntentHandler.IntentHandlerDelegate; 58 import org.chromium.chrome.browser.IntentHandler.IntentHandlerDelegate;
59 import org.chromium.chrome.browser.IntentHandler.TabOpenType; 59 import org.chromium.chrome.browser.IntentHandler.TabOpenType;
60 import org.chromium.chrome.browser.appmenu.AppMenu; 60 import org.chromium.chrome.browser.appmenu.AppMenu;
61 import org.chromium.chrome.browser.appmenu.AppMenuHandler; 61 import org.chromium.chrome.browser.appmenu.AppMenuHandler;
62 import org.chromium.chrome.browser.appmenu.AppMenuObserver; 62 import org.chromium.chrome.browser.appmenu.AppMenuObserver;
63 import org.chromium.chrome.browser.appmenu.AppMenuPropertiesDelegate; 63 import org.chromium.chrome.browser.appmenu.AppMenuPropertiesDelegate;
64 import org.chromium.chrome.browser.bookmarks.BookmarkBridge.BookmarkModelObserve r;
65 import org.chromium.chrome.browser.bookmarks.BookmarkModel; 64 import org.chromium.chrome.browser.bookmarks.BookmarkModel;
66 import org.chromium.chrome.browser.bookmarks.BookmarkUtils; 65 import org.chromium.chrome.browser.bookmarks.BookmarkUtils;
67 import org.chromium.chrome.browser.compositor.CompositorViewHolder; 66 import org.chromium.chrome.browser.compositor.CompositorViewHolder;
68 import org.chromium.chrome.browser.compositor.layouts.Layout; 67 import org.chromium.chrome.browser.compositor.layouts.Layout;
69 import org.chromium.chrome.browser.compositor.layouts.LayoutManager; 68 import org.chromium.chrome.browser.compositor.layouts.LayoutManager;
70 import org.chromium.chrome.browser.compositor.layouts.LayoutManagerDocument; 69 import org.chromium.chrome.browser.compositor.layouts.LayoutManagerDocument;
71 import org.chromium.chrome.browser.compositor.layouts.SceneChangeObserver; 70 import org.chromium.chrome.browser.compositor.layouts.SceneChangeObserver;
72 import org.chromium.chrome.browser.compositor.layouts.content.ContentOffsetProvi der; 71 import org.chromium.chrome.browser.compositor.layouts.content.ContentOffsetProvi der;
73 import org.chromium.chrome.browser.compositor.layouts.content.TabContentManager; 72 import org.chromium.chrome.browser.compositor.layouts.content.TabContentManager;
74 import org.chromium.chrome.browser.contextualsearch.ContextualSearchFieldTrial; 73 import org.chromium.chrome.browser.contextualsearch.ContextualSearchFieldTrial;
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 private ChromeFullscreenManager mFullscreenManager; 212 private ChromeFullscreenManager mFullscreenManager;
214 private CompositorViewHolder mCompositorViewHolder; 213 private CompositorViewHolder mCompositorViewHolder;
215 private InsetObserverView mInsetObserverView; 214 private InsetObserverView mInsetObserverView;
216 private ContextualSearchManager mContextualSearchManager; 215 private ContextualSearchManager mContextualSearchManager;
217 private ReaderModeManager mReaderModeManager; 216 private ReaderModeManager mReaderModeManager;
218 private SnackbarManager mSnackbarManager; 217 private SnackbarManager mSnackbarManager;
219 private DataUseSnackbarController mDataUseSnackbarController; 218 private DataUseSnackbarController mDataUseSnackbarController;
220 private AppMenuPropertiesDelegate mAppMenuPropertiesDelegate; 219 private AppMenuPropertiesDelegate mAppMenuPropertiesDelegate;
221 private AppMenuHandler mAppMenuHandler; 220 private AppMenuHandler mAppMenuHandler;
222 private ToolbarManager mToolbarManager; 221 private ToolbarManager mToolbarManager;
223 private BookmarkModelObserver mBookmarkObserver;
224 222
225 // Time in ms that it took took us to inflate the initial layout 223 // Time in ms that it took took us to inflate the initial layout
226 private long mInflateInitialLayoutDurationMs; 224 private long mInflateInitialLayoutDurationMs;
227 225
228 private int mScreenWidthDp; 226 private int mScreenWidthDp;
229 private Runnable mRecordMultiWindowModeScreenWidthRunnable; 227 private Runnable mRecordMultiWindowModeScreenWidthRunnable;
230 228
231 private AssistStatusHandler mAssistStatusHandler; 229 private AssistStatusHandler mAssistStatusHandler;
232 230
233 // A set of views obscuring all tabs. When this set is nonempty, 231 // A set of views obscuring all tabs. When this set is nonempty,
(...skipping 1591 matching lines...) Expand 10 before | Expand all | Expand 10 after
1825 "Android.MultiWindowMode.IsTabletScreenWidthBelow600", 1823 "Android.MultiWindowMode.IsTabletScreenWidthBelow600",
1826 mScreenWidthDp < DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP); 1824 mScreenWidthDp < DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP);
1827 1825
1828 if (mScreenWidthDp < DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP) { 1826 if (mScreenWidthDp < DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP) {
1829 RecordHistogram.recordLinearCountHistogram( 1827 RecordHistogram.recordLinearCountHistogram(
1830 "Android.MultiWindowMode.TabletScreenWidth", mScreenWidthDp, 1, 1828 "Android.MultiWindowMode.TabletScreenWidth", mScreenWidthDp, 1,
1831 DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP, 50); 1829 DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP, 50);
1832 } 1830 }
1833 } 1831 }
1834 } 1832 }
OLDNEW
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698