src/ia32/lithium-codegen-ia32.cc - Issue 20323002: Add Smi support to Shl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/lithium-codegen-ia32.cc

Issue 20323002: Add Smi support to Shl (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: ARM / x64 Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/lithium-codegen-ia32.cc

diff --git a/src/ia32/lithium-codegen-ia32.cc b/src/ia32/lithium-codegen-ia32.cc

index d022a82f4df540d5078dcdebc184eb3bba1566fd..de936b4a18edd79fd8371f1af201e6436389f952 100644

--- a/src/ia32/lithium-codegen-ia32.cc

+++ b/src/ia32/lithium-codegen-ia32.cc

@@ -1762,7 +1762,14 @@ void LCodeGen::DoShiftI(LShiftI* instr) {

break;

case Token::SHL:

if (shift_count != 0) {

- __ shl(ToRegister(left), shift_count);

+ if (instr->hydrogen_value()->representation().IsSmi() &&

+ instr->can_deopt()) {

+ __ shl(ToRegister(left), shift_count - 1);

+ __ SmiTag(ToRegister(left));

+ DeoptimizeIf(overflow, instr->environment());

+ } else {

+ __ shl(ToRegister(left), shift_count);

+ }

}

break;

default: