Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 20323002: Add Smi support to Shl (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: ARM / x64 Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« src/ia32/lithium-ia32.cc ('K') | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 699 matching lines...) Expand 10 before | Expand all | Expand 10 after
710 } 710 }
711 711
712 712
713 LInstruction* LChunkBuilder::DoDeoptimize(HDeoptimize* instr) { 713 LInstruction* LChunkBuilder::DoDeoptimize(HDeoptimize* instr) {
714 return AssignEnvironment(new(zone()) LDeoptimize); 714 return AssignEnvironment(new(zone()) LDeoptimize);
715 } 715 }
716 716
717 717
718 LInstruction* LChunkBuilder::DoShift(Token::Value op, 718 LInstruction* LChunkBuilder::DoShift(Token::Value op,
719 HBitwiseBinaryOperation* instr) { 719 HBitwiseBinaryOperation* instr) {
720 if (instr->representation().IsSmiOrTagged()) { 720 if (instr->representation().IsTagged()) {
721 ASSERT(instr->left()->representation().IsSmiOrTagged()); 721 ASSERT(instr->left()->representation().IsTagged());
722 ASSERT(instr->right()->representation().IsSmiOrTagged()); 722 ASSERT(instr->right()->representation().IsTagged());
723 723
724 LOperand* left = UseFixed(instr->left(), rdx); 724 LOperand* left = UseFixed(instr->left(), rdx);
725 LOperand* right = UseFixed(instr->right(), rax); 725 LOperand* right = UseFixed(instr->right(), rax);
726 LArithmeticT* result = new(zone()) LArithmeticT(op, left, right); 726 LArithmeticT* result = new(zone()) LArithmeticT(op, left, right);
727 return MarkAsCall(DefineFixed(result, rax), instr); 727 return MarkAsCall(DefineFixed(result, rax), instr);
728 } 728 }
729 729
730 ASSERT(instr->representation().IsInteger32()); 730 ASSERT(instr->representation().IsSmiOrInteger32());
731 ASSERT(instr->left()->representation().IsInteger32()); 731 ASSERT(instr->left()->representation().Equals(instr->representation()));
732 ASSERT(instr->right()->representation().IsInteger32()); 732 ASSERT(instr->right()->representation().Equals(instr->representation()));
733 LOperand* left = UseRegisterAtStart(instr->left()); 733 LOperand* left = UseRegisterAtStart(instr->left());
734 734
735 HValue* right_value = instr->right(); 735 HValue* right_value = instr->right();
736 LOperand* right = NULL; 736 LOperand* right = NULL;
737 int constant_value = 0; 737 int constant_value = 0;
738 if (right_value->IsConstant()) { 738 if (right_value->IsConstant()) {
739 HConstant* constant = HConstant::cast(right_value); 739 HConstant* constant = HConstant::cast(right_value);
740 right = chunk_->DefineConstantOperand(constant); 740 right = chunk_->DefineConstantOperand(constant);
741 constant_value = constant->Integer32Value() & 0x1f; 741 constant_value = constant->Integer32Value() & 0x1f;
742 } else { 742 } else {
(...skipping 1820 matching lines...) Expand 10 before | Expand all | Expand 10 after
2563 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2563 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2564 LOperand* object = UseRegister(instr->object()); 2564 LOperand* object = UseRegister(instr->object());
2565 LOperand* index = UseTempRegister(instr->index()); 2565 LOperand* index = UseTempRegister(instr->index());
2566 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2566 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2567 } 2567 }
2568 2568
2569 2569
2570 } } // namespace v8::internal 2570 } } // namespace v8::internal
2571 2571
2572 #endif // V8_TARGET_ARCH_X64 2572 #endif // V8_TARGET_ARCH_X64
OLDNEW
« src/ia32/lithium-ia32.cc ('K') | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698