Issue 20323002: Add Smi support to Shl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20323002: Add Smi support to Shl (Closed)

Created:
7 years, 4 months ago by Toon Verwaest

Modified:
7 years, 4 months ago

Reviewers:
mvstanton

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add Smi support to Shl R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15910

Patch Set 2 : ARM / x64 #

Total comments: 2

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -22 lines)			Patch
M	src/arm/lithium-arm.cc	View	1	2 chunks	+17 lines, -7 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1	1 chunk	+8 lines, -1 line	0 comments	Download
M	src/hydrogen-instructions.h	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View		1 chunk	+8 lines, -1 line	0 comments	Download
M	src/ia32/lithium-ia32.cc	View		2 chunks	+15 lines, -5 lines	2 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/x64/lithium-x64.cc	View	1	2 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mvstanton

lgtm https://chromiumcodereview.appspot.com/20323002/diff/2001/src/ia32/lithium-ia32.cc File src/ia32/lithium-ia32.cc (right): https://chromiumcodereview.appspot.com/20323002/diff/2001/src/ia32/lithium-ia32.cc#newcode788 src/ia32/lithium-ia32.cc:788: // Left shifts can deoptimize if we shift ...

7 years, 4 months ago (2013-07-26 13:34:48 UTC) #2

Toon Verwaest

7 years, 4 months ago (2013-07-26 13:35:51 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r15910 (presubmit successful).

Expand Messages | Collapse Messages

Issue 20323002: Add Smi support to Shl (Closed)

Description

Patch Set 1 #

Patch Set 2 : ARM / x64 #

Messages