chrome/android/shell/res/menu/main_menu.xml - Issue 203173008: Cleanup Icon Row custom code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/shell/res/menu/main_menu.xml

Issue 203173008: Cleanup Icon Row custom code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuDragHelper.java ('K') | « chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/shell/res/menu/main_menu.xml

diff --git a/chrome/android/shell/res/menu/main_menu.xml b/chrome/android/shell/res/menu/main_menu.xml

index a62a9bdbab50caa79082f2161f5a80451d8060cf..9a99611147e591846bc3e96f9f2d86d0c3c1e348 100644

--- a/chrome/android/shell/res/menu/main_menu.xml

+++ b/chrome/android/shell/res/menu/main_menu.xml

@@ -8,24 +8,34 @@

<group android:id="@+id/MAIN_MENU"

android:visible="false">

+ <item>

+ <menu>

+ <item android:id="@+id/back_menu_id"

+ android:title="@string/accessibility_menu_back"

+ android:icon="@drawable/back_button_selector"/>

+ <item android:id="@+id/forward_menu_id"

+ android:title="@string/accessibility_menu_forward"

+ android:icon="@drawable/forward_button_selector"/>

+ <item android:id="@+id/bookmark_this_page_id"

+ android:title="@string/accessibility_menu_bookmark"

+ android:icon="@drawable/star"/>

+ </menu>

+ </item>

<item android:id="@+id/signin"

android:title="@string/signin_sign_in" />

<item android:id="@+id/print"

android:title="@string/print_menu" />

<item android:id="@+id/distill_page"

android:title="@string/distill_page_menu" />

- </group>

- <group android:id="@+id/PHONE_ICON_MENU_ITEMS"

- android:visible="false">

- <!-- These items are never made visible in the default list. They are only used

- to pass through the clicks from the icon row in the custom menu. -->

- <item android:id="@+id/back_menu_id"

- android:title="@null" />

- <item android:id="@+id/forward_menu_id"

- android:title="@null" />

- <item android:id="@+id/bookmark_this_page_id"

- android:title="@null" />

+ <item>

+ <menu>

+ <item android:id="@+id/share_menu_id"

+ android:title="Share"/>

+ <item android:id="@+id/share_direct_menu_id"

+ android:title="boom2"

+ android:icon="@drawable/star"/>

+ </menu>

+ </item>

</group>

</menu>