Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2031263002:
gpu: Allow framebuffers with mixed samples if the hw supports it (Closed)
|
Created:
4 years, 6 months ago by Kimmo Kinnunen Modified:
4 years, 6 months ago CC:
chromium-reviews, piman+watch_chromium.org, Ken Russell (switch to Gerrit) Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptiongpu: Allow framebuffers with mixed samples if the hw supports it
Allow framebuffers with mixed samples if the hw supports it.
The commit "Check samples matching for framebuffer attachments."
regressed this.
The HW that support this include NVIDIA GTX 980 (desktop, "GM20X" chips)
and SHIELD TV (Android, "X1" chips).
BUG=429053
TEST=gl_tests --gtest_filter=CHROMIUMFramebufferMixedSamplesTest*
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/20c8f5f846d3ade7539678d6cbd05e3cd6fd0b16
Cr-Commit-Position: refs/heads/master@{#398288}
Patch Set 1 #Patch Set 2 : rebase #
Messages
Total messages: 24 (11 generated)
Description was changed from ========== gpu: Allow framebuffers with mixed samples if the hw supports it Allow framebuffers with mixed samples if the hw supports it. The commit "Check samples matching for framebuffer attachments." regressed this. The HW that support this include NVIDIA GTX 980 (desktop, "GM20X" chips) and SHIELD TV (Android, "X1" chips). BUG=429053 TEST=gl_tests --gtest_filter=CHROMIUMFramebufferMixedSamplesTest* ========== to ========== gpu: Allow framebuffers with mixed samples if the hw supports it Allow framebuffers with mixed samples if the hw supports it. The commit "Check samples matching for framebuffer attachments." regressed this. The HW that support this include NVIDIA GTX 980 (desktop, "GM20X" chips) and SHIELD TV (Android, "X1" chips). BUG=429053 TEST=gl_tests --gtest_filter=CHROMIUMFramebufferMixedSamplesTest* CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
kkinnunen@nvidia.com changed reviewers: + piman@chromium.org, zmo@chromium.org
Would it make sense for us to provide some HW for the buildbots?
Ah sorry about the regression. lgtm
Talk with kbr about extra hardware config for chromium testing.
lgtm
The CQ bit was checked by kkinnunen@nvidia.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031263002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
The CQ bit was checked by kkinnunen@nvidia.com
The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org, piman@chromium.org Link to the patchset: https://chromiumcodereview.appspot.com/2031263002/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031263002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by kkinnunen@nvidia.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031263002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by kkinnunen@nvidia.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031263002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== gpu: Allow framebuffers with mixed samples if the hw supports it Allow framebuffers with mixed samples if the hw supports it. The commit "Check samples matching for framebuffer attachments." regressed this. The HW that support this include NVIDIA GTX 980 (desktop, "GM20X" chips) and SHIELD TV (Android, "X1" chips). BUG=429053 TEST=gl_tests --gtest_filter=CHROMIUMFramebufferMixedSamplesTest* CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== gpu: Allow framebuffers with mixed samples if the hw supports it Allow framebuffers with mixed samples if the hw supports it. The commit "Check samples matching for framebuffer attachments." regressed this. The HW that support this include NVIDIA GTX 980 (desktop, "GM20X" chips) and SHIELD TV (Android, "X1" chips). BUG=429053 TEST=gl_tests --gtest_filter=CHROMIUMFramebufferMixedSamplesTest* CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/20c8f5f846d3ade7539678d6cbd05e3cd6fd0b16 Cr-Commit-Position: refs/heads/master@{#398288} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/20c8f5f846d3ade7539678d6cbd05e3cd6fd0b16 Cr-Commit-Position: refs/heads/master@{#398288} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
