Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 20284003: Simplify cq url match rules and add http urls (Closed)

Created:
7 years, 5 months ago by Isaac (away)
Modified:
7 years, 5 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, iannucci
Base URL:
https://chromium.googlesource.com/chromium/tools/commit-queue@master
Visibility:
Public.

Description

Simplify cq url match rules and add http urls BUG=238287 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=213762

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -49 lines) Patch
M projects.py View 1 4 chunks +20 lines, -33 lines 0 comments Download
M tests/project_test.py View 1 chunk +6 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Isaac (away)
7 years, 5 months ago (2013-07-25 10:35:35 UTC) #1
M-A Ruel
lgtm
7 years, 5 months ago (2013-07-25 11:15:30 UTC) #2
Isaac (away)
I tested this locally and think it's OK. That being said -- I'll watch cq ...
7 years, 5 months ago (2013-07-26 04:13:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/20284003/3001
7 years, 5 months ago (2013-07-26 04:14:13 UTC) #4
commit-bot: I haz the power
7 years, 5 months ago (2013-07-26 04:14:35 UTC) #5
Message was sent while issue was closed.
Change committed as 213762

Powered by Google App Engine
This is Rietveld 408576698