media: Mark Widevine CDM and manifest as data_deps of the adapter

third_party/widevine/cdm/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chrome_build.gni")
 import("//build/config/features.gni")
 import("//chrome/version.gni")  # TODO layering violation
 import("//media/cdm/ppapi/cdm_paths.gni")
 import("//media/cdm/ppapi/ppapi_cdm_adapter.gni")
 import("//third_party/widevine/cdm/widevine.gni")
@@ skipping 125 matching lines @@
       "widevinecdmadapter.ver",
     ]
     output = "$target_gen_dir/widevinecdmadapter_version.rc"
   }
 
   ppapi_cdm_adapter("widevinecdmadapter") {
     defines = []
     output_dir = "$root_out_dir/$widevine_cdm_path"
     deps = [
       ":version_h",
+      ":widevinecdm",
+      ":widevinecdmadapter_resources",
+    ]
+    data_deps = [
       ":widevine_cdm_manifest",
       ":widevinecdm",

[ddorwin, 2016/06/01 20:16:43]

deps doesn't imply data_deps?

[xhwang, 2016/06/01 20:24:12]

Apparently not based on "gn help runtime_deps" unless it's a shared library:

  To a first approximation, the runtime dependencies of a target are
  the set of "data" files, data directories, and the shared libraries
  from all transitive dependencies.

[Dirk Pranke, 2016/06/01 21:33:16]

Correct, `deps` does not imply `data_deps`. You might depend on `protoc` in
order to generate the proto buffer stubs, but that doesn't mean you need the
protocol compiler itself to be present at runtime.

-      ":widevinecdmadapter_resources",
     ]
 
     if (is_linux) {
       ldflags =
           [ rebase_path("$root_out_dir/$widevine_cdm_path/libwidevinecdm.so",
                         root_build_dir) ]
     } else if (is_win) {
       ldflags =
           [ rebase_path("$root_out_dir/$widevine_cdm_path/widevinecdm.dll.lib",
                         root_build_dir) ]
@@ skipping 13 matching lines @@
 # on the license server.
 source_set("widevine_test_license_server") {
   if (is_chrome_branded && is_linux) {
     deps = [
       # TODO(jrummell)
       # This target should be removed and targets should have data_deps on this target:
       #"//third_party/widevine/test/license_server/license_server.gyp:test_license_server"
     ]
   }
 }