Issue 20265003: mesa should not to use X11 headers when use_x11==0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20265003: mesa should not to use X11 headers when use_x11==0 (Closed)

Created:
7 years, 5 months ago by Mostyn Bramley-Moore

Modified:
7 years, 5 months ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

mesa should not to use X11 headers when use_x11==0 Mesa checks if MESA_EGL_NO_X11_HEADERS is defined before trying to include X11 headers, we should set this if use_x11==0. BUG=238755 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213918

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	third_party/mesa/mesa.gyp	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

Ken Russell (switch to Gerrit)

Out of curiosity: where is the BUG= line in the CL description? What motivated this ...

7 years, 5 months ago (2013-07-26 00:49:42 UTC) #3

Mostyn Bramley-Moore

> Out of curiosity: where is the BUG= line in the CL description? What motivated ...

7 years, 5 months ago (2013-07-26 07:48:36 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/20265003/1

7 years, 5 months ago (2013-07-26 08:10:17 UTC) #5

Message was sent while issue was closed.

Change committed as 213918