Issue 20262003: Use Platform::queryUsageAndQuota and deprecate WebFrameClient::queryUsageAndQuota

Issue 20262003: Use Platform::queryUsageAndQuota and deprecate WebFrameClient::queryUsageAndQuota (Closed)

Created:
7 years, 5 months ago by kinuko

Modified:
7 years, 4 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, kinuko, jamesr, dglazkov+blink, eae+blinkwatch, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Use Platform::queryUsageAndQuota and deprecate WebFrameClient::queryUsageAndQuota - Removes WebFrameClient::queryUsageAndQuota - Re-implements StorageQuota::queryUsageAndQuota using Platform::queryUsageAndQuota - Moves WebStorageQuotaCallbacksImpl from Source/web to modules/quota - Deprecates all worker-specific code for queryUsageAndQuota This depends on chromium-side change: https://codereview.chromium.org/20015002/ BUG=259660 TEST=should have no behaviral changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155084

Patch Set 1 : #

Total comments: 3

Patch Set 2 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -597 lines)			Patch
M	Source/modules/modules.gypi	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/modules/quota/StorageQuota.cpp	View		2 chunks	+32 lines, -1 line	0 comments	Download
A +	Source/modules/quota/WebStorageQuotaCallbacksImpl.h	View		1 chunk	+26 lines, -17 lines	0 comments	Download
A +	Source/modules/quota/WebStorageQuotaCallbacksImpl.cpp	View		2 chunks	+9 lines, -14 lines	0 comments	Download
M	Source/web/StorageQuotaChromium.cpp	View		3 chunks	+3 lines, -37 lines	0 comments	Download
D	Source/web/WebStorageQuotaCallbacksImpl.h	View		1 chunk	+0 lines, -67 lines	0 comments	Download
D	Source/web/WebStorageQuotaCallbacksImpl.cpp	View		1 chunk	+0 lines, -81 lines	0 comments	Download
M	Source/web/WebWorkerClientImpl.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/web/WebWorkerClientImpl.cpp	View		1 chunk	+0 lines, -9 lines	0 comments	Download
D	Source/web/WorkerStorageQuotaCallbacksBridge.h	View		1 chunk	+0 lines, -120 lines	0 comments	Download
D	Source/web/WorkerStorageQuotaCallbacksBridge.cpp	View		1 chunk	+0 lines, -230 lines	0 comments	Download
M	Source/web/web.gypi	View		2 chunks	+0 lines, -4 lines	0 comments	Download
M	public/web/WebCommonWorkerClient.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	public/web/WebFrameClient.h	View		1 chunk	+0 lines, -11 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

LGTM https://codereview.chromium.org/20262003/diff/1016/Source/modules/quota/WebStorageQuotaCallbacksImpl.cpp File Source/modules/quota/WebStorageQuotaCallbacksImpl.cpp (right): https://codereview.chromium.org/20262003/diff/1016/Source/modules/quota/WebStorageQuotaCallbacksImpl.cpp#newcode57 Source/modules/quota/WebStorageQuotaCallbacksImpl.cpp:57: OwnPtr<WebStorageQuotaCallbacksImpl> deleter = adoptPtr(this); Yuck. Can we not ...

7 years, 5 months ago (2013-07-25 07:42:27 UTC) #2

kinuko

https://codereview.chromium.org/20262003/diff/1016/Source/web/WebStorageQuotaCallbacksImpl.cpp File Source/web/WebStorageQuotaCallbacksImpl.cpp (left): https://codereview.chromium.org/20262003/diff/1016/Source/web/WebStorageQuotaCallbacksImpl.cpp#oldcode64 Source/web/WebStorageQuotaCallbacksImpl.cpp:64: delete this; On 2013/07/25 07:42:27, abarth wrote: > Boo ...

7 years, 5 months ago (2013-07-25 07:58:42 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/20262003/10001

7 years, 4 months ago (2013-07-29 06:57:32 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/20262003/10001

7 years, 4 months ago (2013-07-29 11:55:41 UTC) #6

Message was sent while issue was closed.

Change committed as 155084

Expand Messages | Collapse Messages