Issue 20258002: Remove mystery keyboard layout from Chrome OS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20258002: Remove mystery keyboard layout from Chrome OS. (Closed)

Created:
7 years, 5 months ago by Seigo Nonaka

Modified:
7 years, 4 months ago

Reviewers:
Zachary Kuznia

CC:
chromium-reviews, nona+watch_chromium.org, stevenjb+watch_chromium.org, yusukes+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove mystery keyboard layout from Chrome OS. BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215129

Patch Set 1 #

Patch Set 2 : Remove obsolete test code #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -10 lines)			Patch
	M	chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc	View	1	1 chunk	+2 lines, -9 lines	0 comments	Download
	M	chromeos/ime/input_methods.txt	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Seigo Nonaka

Hi Zach, Could you take a look? I got approval for removing this layout from ...

7 years, 5 months ago (2013-07-25 05:50:45 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/20258002/1

7 years, 4 months ago (2013-07-31 04:41:43 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=140769

7 years, 4 months ago (2013-07-31 06:02:08 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/20258002/23001

7 years, 4 months ago (2013-08-01 17:18:05 UTC) #5

Message was sent while issue was closed.

Change committed as 215129

Expand Messages | Collapse Messages