Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3456)

Unified Diff: chrome/browser/extensions/shell_window_registry.cc

Issue 20243003: Fix crash when reloading packaged app. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase to after mac app shim fix Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/shell_window_registry.cc
diff --git a/chrome/browser/extensions/shell_window_registry.cc b/chrome/browser/extensions/shell_window_registry.cc
index b9c939d1d090f9b86f7946149cf126bea8a5dc48..216da68bf277891f04d54ef9a022358269551405 100644
--- a/chrome/browser/extensions/shell_window_registry.cc
+++ b/chrome/browser/extensions/shell_window_registry.cc
@@ -85,9 +85,10 @@ void ShellWindowRegistry::RemoveShellWindow(ShellWindow* shell_window) {
const ShellWindowList::iterator it = std::find(shell_windows_.begin(),
shell_windows_.end(),
shell_window);
- if (it != shell_windows_.end())
+ if (it != shell_windows_.end()) {
shell_windows_.erase(it);
- FOR_EACH_OBSERVER(Observer, observers_, OnShellWindowRemoved(shell_window));
+ FOR_EACH_OBSERVER(Observer, observers_, OnShellWindowRemoved(shell_window));
+ }
}
void ShellWindowRegistry::AddObserver(Observer* observer) {
« no previous file with comments | « chrome/browser/extensions/platform_app_browsertest.cc ('k') | chrome/browser/ui/cocoa/extensions/native_app_window_cocoa.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698