Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 20238002: GCP2.0 Device: XMPP (without pings). (Closed)

Created:
7 years, 5 months ago by maksymb
Modified:
7 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@DEPS-jingle
Visibility:
Public.

Description

GCP2.0 Device: XMPP (without pings). BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215334

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : Reindent #

Patch Set 6 : Fixed Lint errors #

Patch Set 7 : Little bugfix #

Patch Set 8 : #

Patch Set 9 : XMPP Reconnect added #

Total comments: 3

Patch Set 10 : Deleted Retry workflow. #

Patch Set 11 : #

Total comments: 2

Patch Set 12 : #

Patch Set 13 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+659 lines, -161 lines) Patch
M cloud_print/gcp20/prototype/cloud_print_requester.h View 1 6 chunks +21 lines, -9 lines 0 comments Download
M cloud_print/gcp20/prototype/cloud_print_requester.cc View 1 2 3 4 5 12 chunks +28 lines, -61 lines 0 comments Download
M cloud_print/gcp20/prototype/cloud_print_response_parser.h View 1 chunk +2 lines, -1 line 0 comments Download
M cloud_print/gcp20/prototype/cloud_print_response_parser.cc View 2 chunks +9 lines, -1 line 0 comments Download
A cloud_print/gcp20/prototype/cloud_print_url_request_context_getter.h View 1 2 3 4 5 1 chunk +36 lines, -0 lines 0 comments Download
A cloud_print/gcp20/prototype/cloud_print_url_request_context_getter.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +37 lines, -0 lines 0 comments Download
A cloud_print/gcp20/prototype/cloud_print_xmpp_listener.h View 1 2 3 4 5 6 7 8 9 1 chunk +96 lines, -0 lines 0 comments Download
A cloud_print/gcp20/prototype/cloud_print_xmpp_listener.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +108 lines, -0 lines 0 comments Download
M cloud_print/gcp20/prototype/gcp20_device.cc View 1 2 chunks +12 lines, -4 lines 0 comments Download
M cloud_print/gcp20/prototype/gcp20_device.gyp View 1 chunk +6 lines, -1 line 0 comments Download
M cloud_print/gcp20/prototype/printer.h View 1 2 3 4 7 chunks +64 lines, -15 lines 0 comments Download
M cloud_print/gcp20/prototype/printer.cc View 1 2 3 4 5 6 7 8 9 10 15 chunks +240 lines, -69 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
maksymb
Please take a look at my CL.
7 years, 5 months ago (2013-07-25 03:27:41 UTC) #1
gene
lgtm Your printer class is grows and now over 700 lines. You may consider splitting ...
7 years, 5 months ago (2013-07-25 20:36:53 UTC) #2
maksymb
https://codereview.chromium.org/20238002/diff/6001/cloud_print/gcp20/prototype/printer.h File cloud_print/gcp20/prototype/printer.h (right): https://codereview.chromium.org/20238002/diff/6001/cloud_print/gcp20/prototype/printer.h#newcode118 cloud_print/gcp20/prototype/printer.h:118: const std::string& refresh_token, On 2013/07/25 20:36:54, gene wrote: > ...
7 years, 5 months ago (2013-07-25 20:54:46 UTC) #3
maksymb
https://codereview.chromium.org/20238002/diff/69001/cloud_print/gcp20/prototype/cloud_print_xmpp_listener.cc File cloud_print/gcp20/prototype/cloud_print_xmpp_listener.cc (right): https://codereview.chromium.org/20238002/diff/69001/cloud_print/gcp20/prototype/cloud_print_xmpp_listener.cc#newcode92 cloud_print/gcp20/prototype/cloud_print_xmpp_listener.cc:92: ReconnectInternal(); Do I need to call delegate's ObNewLocalSettings, OnNewPrintJob ...
7 years, 4 months ago (2013-07-29 18:59:32 UTC) #4
gene
https://codereview.chromium.org/20238002/diff/69001/cloud_print/gcp20/prototype/cloud_print_xmpp_listener.cc File cloud_print/gcp20/prototype/cloud_print_xmpp_listener.cc (right): https://codereview.chromium.org/20238002/diff/69001/cloud_print/gcp20/prototype/cloud_print_xmpp_listener.cc#newcode92 cloud_print/gcp20/prototype/cloud_print_xmpp_listener.cc:92: ReconnectInternal(); On 2013/07/29 18:59:32, maksymb wrote: > Do I ...
7 years, 4 months ago (2013-07-30 22:46:25 UTC) #5
maksymb
https://codereview.chromium.org/20238002/diff/69001/cloud_print/gcp20/prototype/cloud_print_xmpp_listener.cc File cloud_print/gcp20/prototype/cloud_print_xmpp_listener.cc (right): https://codereview.chromium.org/20238002/diff/69001/cloud_print/gcp20/prototype/cloud_print_xmpp_listener.cc#newcode92 cloud_print/gcp20/prototype/cloud_print_xmpp_listener.cc:92: ReconnectInternal(); On 2013/07/30 22:46:25, gene wrote: > On 2013/07/29 ...
7 years, 4 months ago (2013-07-30 23:25:22 UTC) #6
gene
lgtm small nit below https://codereview.chromium.org/20238002/diff/84001/cloud_print/gcp20/prototype/cloud_print_url_request_context_getter.cc File cloud_print/gcp20/prototype/cloud_print_url_request_context_getter.cc (right): https://codereview.chromium.org/20238002/diff/84001/cloud_print/gcp20/prototype/cloud_print_url_request_context_getter.cc#newcode21 cloud_print/gcp20/prototype/cloud_print_url_request_context_getter.cc:21: CloudPrintURLRequestContextGetter::GetURLRequestContext() { I think this ...
7 years, 4 months ago (2013-08-02 00:39:47 UTC) #7
maksymb
https://codereview.chromium.org/20238002/diff/84001/cloud_print/gcp20/prototype/cloud_print_url_request_context_getter.cc File cloud_print/gcp20/prototype/cloud_print_url_request_context_getter.cc (right): https://codereview.chromium.org/20238002/diff/84001/cloud_print/gcp20/prototype/cloud_print_url_request_context_getter.cc#newcode21 cloud_print/gcp20/prototype/cloud_print_url_request_context_getter.cc:21: CloudPrintURLRequestContextGetter::GetURLRequestContext() { On 2013/08/02 00:39:47, gene wrote: > I ...
7 years, 4 months ago (2013-08-02 01:22:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maksymb@chromium.org/20238002/89001
7 years, 4 months ago (2013-08-02 01:24:19 UTC) #9
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 4 months ago (2013-08-02 02:32:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maksymb@chromium.org/20238002/110001
7 years, 4 months ago (2013-08-02 16:58:07 UTC) #11
commit-bot: I haz the power
7 years, 4 months ago (2013-08-02 18:58:44 UTC) #12
Message was sent while issue was closed. 
Change committed as 215334

Powered by Google App Engine
This is Rietveld 408576698