Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1835)

Unified Diff: android_webview/public/browser/draw_sw.h

Issue 20234002: Make the AwPixelInfo more skia version independent (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix glue compat Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/browser/in_process_view_renderer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/public/browser/draw_sw.h
diff --git a/android_webview/public/browser/draw_sw.h b/android_webview/public/browser/draw_sw.h
index 2cdb45b3f3f2bb8195ddfdf33c87446a4ed5770b..632b970c34880c7c59db89deb298ee91e79050fc 100644
--- a/android_webview/public/browser/draw_sw.h
+++ b/android_webview/public/browser/draw_sw.h
@@ -14,16 +14,30 @@
class SkPicture;
+static const int kAwPixelInfoVersion = 2;
+
+// Values of the AwPixelInfo::config field.
+enum AwPixelConfig {
+ AwConfig_RGB_565 = 4,
+ AwConfig_ARGB_4444 = 5,
+ AwConfig_ARGB_8888 = 6,
+};
+
// Holds the information required to implement the SW draw to system canvas.
struct AwPixelInfo {
- int config; // In SkBitmap::Config format.
- int width; // In pixels.
- int height; // In pixels.
- int row_bytes; // Number of bytes from start of one line to next.
- void* pixels; // The pixels, all (height * row_bytes) of them.
- float matrix[9]; // The matrix currently in effect on the canvas.
- void* clip_region; // Flattened clip region.
- size_t clip_region_size; // Number of bytes in |clip_region|.
+ int version; // The kAwPixelInfoVersion this struct was built with.
+ int config; // |pixel| format: a value from AwPixelConfig.
+ int width; // In pixels.
+ int height; // In pixels.
+ int row_bytes; // Number of bytes from start of one line to next.
+ void* pixels; // The pixels, all (height * row_bytes) of them.
+ // The Matrix and Clip are relative to |pixels|, not the source canvas.
+ float matrix[9]; // The matrix currently in effect on the canvas.
+ int clip_rect_count; // Number of rects in |clip_rects|.
+ int* clip_rects; // Clip area: 4 ints per rect in {x,y,w,h} format.
+ void* clip_region; // TODO(joth): remove clip_region and clip_region_size.
+ size_t clip_region_size;
+ // NOTE: If you add more members, bump kAwPixelInfoVersion.
};
// Function that can be called to fish out the underlying native pixel data
« no previous file with comments | « android_webview/browser/in_process_view_renderer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698