Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 20228003: Remove test fast/multicol/newmulticol/columns-shorthand-parsing.html (Closed)

Created:
7 years, 5 months ago by mstensho (USE GERRIT)
Modified:
7 years, 5 months ago
Reviewers:
eseidel
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove test fast/multicol/newmulticol/columns-shorthand-parsing.html This test isn't very valuable, since there are plenty of balancing tests already. This test attempted to compare rendering between the old and the new multicol implementations, and for some reason it fails on Mac, albeit not visibly to the naked eye. BUG=254219 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154961

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -214 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/multicol/newmulticol/columns-shorthand-parsing.html View 1 chunk +0 lines, -108 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/columns-shorthand-parsing-expected.html View 1 chunk +0 lines, -105 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mstensho (USE GERRIT)
Try to solve this bug in a completely different way - remove the test! :) ...
7 years, 5 months ago (2013-07-25 12:52:30 UTC) #1
eseidel
lgtm
7 years, 5 months ago (2013-07-25 23:02:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/20228003/1
7 years, 5 months ago (2013-07-25 23:14:11 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-26 02:31:07 UTC) #4
Message was sent while issue was closed.
Change committed as 154961

Powered by Google App Engine
This is Rietveld 408576698