chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionProxyUma.java - Issue 2022313002: UI for the Data Saver InfoBar Promo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionProxyUma.java

Issue 2022313002: UI for the Data Saver InfoBar Promo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@infobarPromo

Patch Set: "tbansal comments" Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoUtils.java ('k') | chrome/android/java_sources.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionProxyUma.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionProxyUma.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionProxyUma.java

index aeafecbd272128611158a8af6d5de3cd1fb24d85..778e444cc9304f5cd4e4e5397cd3d31717dbc8f2 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionProxyUma.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionProxyUma.java

@@ -10,7 +10,7 @@ import org.chromium.base.metrics.RecordHistogram;

* Centralizes UMA data collection for the Data Reduction Proxy.

public class DataReductionProxyUma {

- // Represent the possible user actions in the promo and settings menu. This must

+ // Represent the possible user actions in the promo and settings menu. This must

// remain in sync with DataReductionProxy.UIAction in

// tools/metrics/histograms/histograms.xml.

public static final int ACTION_ENABLED = 0;

@@ -23,7 +23,9 @@ public class DataReductionProxyUma {

public static final int ACTION_ON_TO_ON = 8;

public static final int ACTION_FRE_ENABLED = 9;

public static final int ACTION_FRE_DISABLED = 10;

- public static final int ACTION_INDEX_BOUNDARY = 11;

+ public static final int ACTION_INFOBAR_ENABLED = 11;

+ public static final int ACTION_INFOBAR_DISMISSED = 12;

+ public static final int ACTION_INDEX_BOUNDARY = 13;

// Represent the possible Lo-Fi user actions. This must remain in sync with

// DataReductionProxy.UIAction.LoFi in tools/metrics/histograms/histograms.xml.