chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java - Issue 2022313002: UI for the Data Saver InfoBar Promo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 2022313002: UI for the Data Saver InfoBar Promo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@infobarPromo

Patch Set: dfalcantara comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionPromoInfoBar.java » ('j') | chrome/browser/net/spdyproxy/data_reduction_promo_infobar_delegate_android.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

index 48497696c50d0ce5699d5bb9ed94bb91e6b9d3a4..658f37abaee51dc2eccb50b4baede9b396e40ac4 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

@@ -1005,7 +1005,8 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode

boolean isNavigationToDifferentPage, boolean isFragmentNavigation,

int statusCode) {

DataReductionPromoInfoBar.maybeLaunchPromoInfoBar(ChromeTabbedActivity.this,

- tab.getWebContents(), url, isFragmentNavigation, statusCode);

+ tab.getWebContents(), url, tab.isShowingErrorPage(), isFragmentNavigation,

+ statusCode);

}

};