Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2022313002: UI for the Data Saver InfoBar Promo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@infobarPromo
Patch Set: use message layout Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index f00548c10a523a6f29fdd0534c5f2034c85d37cd..b1d31c6b0601b28f8318617affb8d0f5d213737f 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -7625,6 +7625,10 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
can disable the proxy via a switch on the card. The state of the proxy is
sampled when the First Run Experience is completed and only reported if the
Data Reduction Proxy card was shown.
+
+ The user interactions with the Infobar promo. On Android, there are two
+ actions that dismiss the promo (enable, dismiss). This is sampled when the
+ promo leaves view.
</summary>
</histogram>
@@ -67741,13 +67745,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</enum>
<enum name="DataReductionProxyUIAction" type="int">
- <int value="0" label="Enabled directly from the promo"/>
+ <int value="0" label="Enabled directly from the Second Run promo"/>
<int value="1" label="Enabled then disabled from promo (iOS-only)"/>
<int value="2"
- label="Promo settings link clicked, then enabled from settings"/>
+ label="Second Run promo settings link clicked, then enabled from
+ settings"/>
<int value="3"
- label="Promo settings link clicked, but not enabled from settings"/>
- <int value="4" label="Promo dismissed (no action performed)"/>
+ label="Second Run promo settings link clicked, but not enabled from
+ settings"/>
+ <int value="4" label="Second Run promo dismissed (no action performed)"/>
<int value="5"
label="Arrived at settings menu by another path: entered off, exited
off"/>
@@ -67759,6 +67765,8 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
label="Arrived at settings menu by another path: entered on, exited on"/>
<int value="9" label="Enabled directly from the First Run Experience"/>
<int value="10" label="Disabled directly from the First Run Experience"/>
+ <int value="11" label="Enabled directly from the Infobar promo"/>
+ <int value="12" label="InfoBar promo dismissed (no action performed)"/>
gone 2016/06/27 20:44:58 Dismissed implies a user action.
megjablon 2016/06/27 22:16:44 That's why I have the "(no action performed)". We
</enum>
<enum name="DataUsageReportSubmissionResult" type="int">
@@ -76557,6 +76565,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<int value="60" label="CHROME_WINDOW_ERROR"/>
<int value="61" label="CONFIRM_DANGEROUS_DOWNLOAD"/>
<int value="62" label="WINDOWS_DESKTOP_SEARCH_INFOBAR_DELEGATE"/>
gone 2016/06/27 20:44:58 While you're here, can you add 63 for UPDATE_PASSW
megjablon 2016/06/27 22:16:44 Done.
+ <int value="64" label="DATA_REDUCTION_PROMO_INFOBAR_DELEGATE_ANDROID"/>
</enum>
<enum name="InfoBarResponse" type="int">

Powered by Google App Engine
This is Rietveld 408576698