Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1313)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoUtils.java

Issue 2022313002: UI for the Data Saver InfoBar Promo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@infobarPromo
Patch Set: use app_icon Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoUtils.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoUtils.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoUtils.java
index cc4a382ba25708760e0680dba06ecb9220058bbc..c228f1e6ec67f7df85c4be175b385d497a7f3158 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoUtils.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoUtils.java
@@ -6,8 +6,6 @@ package org.chromium.chrome.browser.preferences.datareduction;
import org.chromium.base.ContextUtils;
import org.chromium.chrome.browser.net.spdyproxy.DataReductionProxySettings;
-import org.chromium.chrome.browser.preferences.PrefServiceBridge;
-import org.chromium.chrome.browser.preferences.PrefServiceBridge.AboutVersionStrings;
/**
* Helper functions for displaying the various data reduction proxy promos. The promo screens
@@ -47,16 +45,15 @@ public class DataReductionPromoUtils {
/**
* Saves shared prefs indicating that the data reduction proxy First Run Experience or second
* run promo screen has been displayed at the current time.
+ *
+ * @param version The version of Chrome that the promo was displayed on.
*/
- public static void saveFreOrSecondRunPromoDisplayed() {
- AboutVersionStrings versionStrings = PrefServiceBridge.getInstance()
- .getAboutVersionStrings();
+ public static void saveFreOrSecondRunPromoDisplayed(String version) {
ContextUtils.getAppSharedPreferences()
.edit()
.putBoolean(SHARED_PREF_DISPLAYED_PROMO, true)
.putLong(SHARED_PREF_DISPLAYED_PROMO_TIME_MS, System.currentTimeMillis())
- .putString(SHARED_PREF_DISPLAYED_PROMO_VERSION,
- versionStrings.getApplicationVersion())
+ .putString(SHARED_PREF_DISPLAYED_PROMO_VERSION, version)
.apply();
}
@@ -109,15 +106,14 @@ public class DataReductionPromoUtils {
/**
* Saves shared prefs indicating that the data reduction proxy InfoBar promo has been displayed
* at the current time.
+ *
+ * @param version The version of Chrome that the promo was displayed on.
*/
- public static void saveInfoBarPromoDisplayed() {
- AboutVersionStrings versionStrings = PrefServiceBridge.getInstance()
- .getAboutVersionStrings();
+ public static void saveInfoBarPromoDisplayed(String version) {
ContextUtils.getAppSharedPreferences()
.edit()
.putBoolean(SHARED_PREF_DISPLAYED_INFOBAR_PROMO, true)
- .putString(SHARED_PREF_DISPLAYED_INFOBAR_PROMO_VERSION,
- versionStrings.getApplicationVersion())
+ .putString(SHARED_PREF_DISPLAYED_INFOBAR_PROMO_VERSION, version)
.apply();
}

Powered by Google App Engine
This is Rietveld 408576698