Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/firstrun/DataReductionProxyFirstRunFragment.java

Issue 2022313002: UI for the Data Saver InfoBar Promo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@infobarPromo
Patch Set: use app_icon Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/firstrun/DataReductionProxyFirstRunFragment.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/DataReductionProxyFirstRunFragment.java b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/DataReductionProxyFirstRunFragment.java
index fa1f5c6973357b781baf6b0489890a7d1862c9bd..9b7143ba262f68eac8a2c9d86cd8bf66ba3bf064 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/DataReductionProxyFirstRunFragment.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/DataReductionProxyFirstRunFragment.java
@@ -14,6 +14,8 @@ import android.widget.Button;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.net.spdyproxy.DataReductionProxySettings;
+import org.chromium.chrome.browser.preferences.PrefServiceBridge;
+import org.chromium.chrome.browser.preferences.PrefServiceBridge.AboutVersionStrings;
import org.chromium.chrome.browser.preferences.datareduction.DataReductionPromoUtils;
/**
@@ -63,6 +65,9 @@ public class DataReductionProxyFirstRunFragment extends FirstRunPage {
@Override
public void onStart() {
super.onStart();
- DataReductionPromoUtils.saveFreOrSecondRunPromoDisplayed();
+ AboutVersionStrings versionStrings = PrefServiceBridge.getInstance()
Raj 2016/06/13 17:52:18 Could you pass no argument to saveFreOrSecondRunPr
megjablon 2016/06/23 23:17:30 Done.
+ .getAboutVersionStrings();
+ DataReductionPromoUtils.saveFreOrSecondRunPromoDisplayed(
+ versionStrings.getApplicationVersion());
}
}

Powered by Google App Engine
This is Rietveld 408576698