UI for the Data Saver InfoBar Promo

chrome/browser/net/spdyproxy/data_reduction_promo_infobar_delegate_android.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/net/spdyproxy/data_reduction_promo_infobar_delegate_android.h"
+
+#include "chrome/browser/android/android_theme_resources.h"
+#include "chrome/browser/infobars/infobar_service.h"
+#include "components/infobars/core/infobar.h"
+#include "components/infobars/core/infobar_delegate.h"
+#include "content/public/browser/web_contents.h"
+#include "grit/components_strings.h"
+#include "jni/DataReductionPromoInfoBarDelegate_jni.h"
+#include "ui/base/l10n/l10n_util.h"
+
+// static
+void DataReductionPromoInfoBarDelegateAndroid::Create(
+    content::WebContents* web_contents) {
+  InfoBarService* infobar_service =
+      InfoBarService::FromWebContents(web_contents);
+  infobar_service->AddInfoBar(
+      DataReductionPromoInfoBarDelegateAndroid::CreateInfoBar(
+          infobar_service,
+          std::unique_ptr<DataReductionPromoInfoBarDelegateAndroid>(

[Peter Kasting, 2016/06/29 06:44:43]

Nit: Prefer base::MakeUnique()

[megjablon, 2016/06/29 17:01:52]

Done.

+              new DataReductionPromoInfoBarDelegateAndroid())));
+}
+
+DataReductionPromoInfoBarDelegateAndroid::
+    DataReductionPromoInfoBarDelegateAndroid()
+    : ConfirmInfoBarDelegate(),
+      java_data_reduction_promo_delegate_() {}

[Peter Kasting, 2016/06/29 06:44:43]

Nit: Don't explicitly write out base class or member initializations that use
the default constructor

[megjablon, 2016/06/29 17:01:52]

Done.

+
+DataReductionPromoInfoBarDelegateAndroid::
+    ~DataReductionPromoInfoBarDelegateAndroid() {
+  JNIEnv* env = base::android::AttachCurrentThread();
+  Java_DataReductionPromoInfoBarDelegate_destroy(env);
+}
+
+// static
+bool DataReductionPromoInfoBarDelegateAndroid::Register(JNIEnv* env) {
+  return RegisterNativesImpl(env);
+}
+
+// static
+void DataReductionPromoInfoBarDelegateAndroid::Launch(
+    JNIEnv* env, jclass, jobject jweb_contents) {
+  content::WebContents* web_contents =
+      content::WebContents::FromJavaWebContents(jweb_contents);
+  DCHECK(web_contents);
+  Create(web_contents);
+}
+
+base::android::ScopedJavaLocalRef<jobject>
+DataReductionPromoInfoBarDelegateAndroid::CreateRenderInfoBar(JNIEnv* env) {
+  java_data_reduction_promo_delegate_.Reset(
+      Java_DataReductionPromoInfoBarDelegate_create(env));
+
+  return Java_DataReductionPromoInfoBarDelegate_showPromoInfoBar(
+      env, java_data_reduction_promo_delegate_.obj());
+}
+
+infobars::InfoBarDelegate::InfoBarIdentifier
+DataReductionPromoInfoBarDelegateAndroid::GetIdentifier() const {
+  return DATA_REDUCTION_PROMO_INFOBAR_DELEGATE_ANDROID;
+}
+
+bool DataReductionPromoInfoBarDelegateAndroid::Accept() {
+  JNIEnv* env = base::android::AttachCurrentThread();
+  Java_DataReductionPromoInfoBarDelegate_accept(env);
+  return true;
+}
+
+base::string16 DataReductionPromoInfoBarDelegateAndroid::GetMessageText()
+    const {
+  return base::string16();

[Peter Kasting, 2016/06/29 06:44:43]

Wow, really?  Seems odd

[megjablon, 2016/06/29 17:01:52]

Strings are all assigned in Java in the same location since we need to be in the
the java infobar class to add the substring.

[Peter Kasting, 2016/06/29 20:48:29]

Ah, might be worth a comment.

+}
+
+// JNI for DataReductionPromoInfoBarDelegate.
+void Launch(JNIEnv* env,
+            const JavaParamRef<jclass>& clazz,
+            const JavaParamRef<jobject>& jweb_contents) {
+  DataReductionPromoInfoBarDelegateAndroid::Launch(env, clazz, jweb_contents);
+}