Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2020853002: Re-enable InfoBarTest#testInfoBarForPopUp (Closed)

Created:
4 years, 6 months ago by gone
Modified:
4 years, 6 months ago
Reviewers:
Yusuf
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable InfoBarTest#testInfoBarForPopUp Looks like a renderer issue on debug builds and not a real test failure. BUG=593003 Committed: https://crrev.com/7b6931415d9cb570158a84ef4acb2e3e99d2c8e9 Cr-Commit-Position: refs/heads/master@{#396899}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
gone
4 years, 6 months ago (2016-05-27 23:55:11 UTC) #2
Yusuf
lgtm
4 years, 6 months ago (2016-05-27 23:59:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020853002/1
4 years, 6 months ago (2016-05-31 18:54:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 19:46:30 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7b6931415d9cb570158a84ef4acb2e3e99d2c8e9 Cr-Commit-Position: refs/heads/master@{#396899}
4 years, 6 months ago (2016-05-31 20:44:41 UTC) #10
gone
4 years, 6 months ago (2016-05-31 23:06:30 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://chromiumcodereview.appspot.com/2030433002/ by dfalcantara@chromium.org.

The reason for reverting is: The renderer issue is causing the test to fail even
on the bots.  Bleh..

Powered by Google App Engine
This is Rietveld 408576698