Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Unified Diff: Source/core/loader/EmptyClients.h

Issue 20191003: Route JS Error Info From Blink to Chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@gclient
Patch Set: Adam's requests Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/loader/EmptyClients.h
diff --git a/Source/core/loader/EmptyClients.h b/Source/core/loader/EmptyClients.h
index 37cd9686b08721f81ed18337ff9be0193133a269..59c766a90a17b305e050f9479d088f103ec24d7b 100644
--- a/Source/core/loader/EmptyClients.h
+++ b/Source/core/loader/EmptyClients.h
@@ -104,7 +104,9 @@ public:
virtual void setResizable(bool) OVERRIDE { }
- virtual void addMessageToConsole(MessageSource, MessageLevel, const String&, unsigned, const String&) OVERRIDE { }
+ virtual bool shouldReportDetailedMessageForContext(v8::Handle<v8::Context>) OVERRIDE { return false; }
+ virtual bool shouldReportDetailedMessageForURL(const String&) OVERRIDE { return false; }
+ virtual void addMessageToConsole(MessageSource, MessageLevel, const String&, unsigned, const String& source, const String& details) OVERRIDE { }
virtual bool canRunBeforeUnloadConfirmPanel() OVERRIDE { return false; }
virtual bool runBeforeUnloadConfirmPanel(const String&, Frame*) OVERRIDE { return true; }

Powered by Google App Engine
This is Rietveld 408576698