Source/core/inspector/InspectorDebuggerAgent.cpp - Issue 20191003: Route JS Error Info From Blink to Chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorDebuggerAgent.cpp

Issue 20191003: Route JS Error Info From Blink to Chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@gclient

Patch Set: Adam's requests Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/inspector/InspectorAgent.h ('K') | « Source/core/inspector/InspectorDebuggerAgent.h ('k') | Source/core/inspector/InspectorInstrumentation.idl » ('j') | Source/core/page/ChromeClient.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorDebuggerAgent.cpp

diff --git a/Source/core/inspector/InspectorDebuggerAgent.cpp b/Source/core/inspector/InspectorDebuggerAgent.cpp

index 7913f0109ed101e148dbbda327719e649261c666..559fd557238591ae7022e1aeba15cb26ac146c68 100644

--- a/Source/core/inspector/InspectorDebuggerAgent.cpp

+++ b/Source/core/inspector/InspectorDebuggerAgent.cpp

@@ -34,6 +34,7 @@

#include "InspectorFrontend.h"

#include "bindings/v8/ScriptDebugServer.h"

#include "bindings/v8/ScriptObject.h"

+#include "core/inspector/ConsoleMessage.h"

#include "core/inspector/ContentSearchUtils.h"

#include "core/inspector/InjectedScript.h"

#include "core/inspector/InjectedScriptManager.h"

@@ -220,6 +221,12 @@ void InspectorDebuggerAgent::addMessageToConsole(MessageSource source, MessageTy

addMessageToConsole(source, type);

}

+void InspectorDebuggerAgent::addMessageToConsole(PassOwnPtr<ConsoleMessage> message, InspectorAgent::CheckFrontendBehavior behavior)

+ if (behavior == InspectorAgent::DontCheckFrontend)

+ addMessageToConsole(message->source(), message->type());

static PassRefPtr<JSONObject> buildObjectForBreakpointCookie(const String& url, int lineNumber, int columnNumber, const String& condition, bool isRegex, bool isAnti)

{