Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: Source/core/inspector/ConsoleMessage.h

Issue 20191003: Route JS Error Info From Blink to Chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@gclient
Patch Set: Adam's requests Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/inspector/ConsoleMessage.cpp » ('j') | Source/core/inspector/InspectorAgent.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/ConsoleMessage.h
diff --git a/Source/core/inspector/ConsoleMessage.h b/Source/core/inspector/ConsoleMessage.h
index 78f4f9f0fed316c95ffa22ad89f1c1b0523f9e96..822c0bcea873c636dccce1efc14c3cc4f796a59f 100644
--- a/Source/core/inspector/ConsoleMessage.h
+++ b/Source/core/inspector/ConsoleMessage.h
@@ -51,9 +51,9 @@ class ConsoleMessage {
WTF_MAKE_NONCOPYABLE(ConsoleMessage); WTF_MAKE_FAST_ALLOCATED;
public:
ConsoleMessage(bool canGenerateCallStack, MessageSource, MessageType, MessageLevel, const String& message);
- ConsoleMessage(bool canGenerateCallStack, MessageSource, MessageType, MessageLevel, const String& message, const String& url, unsigned line, unsigned column, ScriptState*, unsigned long requestIdentifier);
- ConsoleMessage(bool canGenerateCallStack, MessageSource, MessageType, MessageLevel, const String& message, PassRefPtr<ScriptCallStack>, unsigned long requestIdentifier);
- ConsoleMessage(bool canGenerateCallStack, MessageSource, MessageType, MessageLevel, const String& message, PassRefPtr<ScriptArguments>, ScriptState*, unsigned long requestIdentifier);
+ ConsoleMessage(bool canGenerateCallStack, MessageSource, MessageType, MessageLevel, const String& message, const String& executionContextURL, const String& url, unsigned line, unsigned column, ScriptState*, unsigned long requestIdentifier);
+ ConsoleMessage(bool canGenerateCallStack, MessageSource, MessageType, MessageLevel, const String& message, const String& executionContextURL, PassRefPtr<ScriptCallStack>, unsigned long requestIdentifier);
+ ConsoleMessage(bool canGenerateCallStack, MessageSource, MessageType, MessageLevel, const String& message, const String& executionContextURL, PassRefPtr<ScriptArguments>, ScriptState*, unsigned long requestIdentifier);
~ConsoleMessage();
void addToFrontend(InspectorFrontend::Console*, InjectedScriptManager*, bool generatePreview);
@@ -61,6 +61,9 @@ public:
void incrementCount();
void setTimestamp(double timestamp) { m_timestamp = timestamp; }
bool isEqual(ConsoleMessage* msg) const;
+ bool hasGeneratedCallStack() const;
+ void generateCallStack(size_t maxSizeToCapture);
+ PassRefPtr<TypeBuilder::Console::ConsoleMessage> generateJSONWithoutArguments() const;
MessageSource source() const { return m_source; }
const String& message() const { return m_message; }
@@ -79,6 +82,7 @@ private:
String m_message;
RefPtr<ScriptArguments> m_arguments;
RefPtr<ScriptCallStack> m_callStack;
+ String m_executionContextURL;
String m_url;
unsigned m_line;
unsigned m_column;
« no previous file with comments | « no previous file | Source/core/inspector/ConsoleMessage.cpp » ('j') | Source/core/inspector/InspectorAgent.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698