Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: Source/web/WebPagePopupImpl.cpp

Issue 20191003: Route JS Error Info From Blink to Chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@gclient
Patch Set: Adam's requests Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 { 77 {
78 return FloatRect(m_popup->m_windowRectInScreen.x, m_popup->m_windowRectI nScreen.y, m_popup->m_windowRectInScreen.width, m_popup->m_windowRectInScreen.he ight); 78 return FloatRect(m_popup->m_windowRectInScreen.x, m_popup->m_windowRectI nScreen.y, m_popup->m_windowRectInScreen.width, m_popup->m_windowRectInScreen.he ight);
79 } 79 }
80 80
81 virtual void setWindowRect(const FloatRect& rect) OVERRIDE 81 virtual void setWindowRect(const FloatRect& rect) OVERRIDE
82 { 82 {
83 m_popup->m_windowRectInScreen = IntRect(rect); 83 m_popup->m_windowRectInScreen = IntRect(rect);
84 m_popup->widgetClient()->setWindowRect(m_popup->m_windowRectInScreen); 84 m_popup->widgetClient()->setWindowRect(m_popup->m_windowRectInScreen);
85 } 85 }
86 86
87 virtual void addMessageToConsole(MessageSource, MessageLevel, const String& message, unsigned lineNumber, const String&) OVERRIDE 87 virtual void addMessageToConsole(MessageSource, MessageLevel, const String& message, unsigned lineNumber, const String&, const String&) OVERRIDE
88 { 88 {
89 #ifndef NDEBUG 89 #ifndef NDEBUG
90 fprintf(stderr, "CONSOLE MESSSAGE:%u: %s\n", lineNumber, message.utf8(). data()); 90 fprintf(stderr, "CONSOLE MESSSAGE:%u: %s\n", lineNumber, message.utf8(). data());
91 #else 91 #else
92 UNUSED_PARAM(message); 92 UNUSED_PARAM(message);
93 UNUSED_PARAM(lineNumber); 93 UNUSED_PARAM(lineNumber);
94 #endif 94 #endif
95 } 95 }
96 96
97 virtual void invalidateContentsAndRootView(const IntRect& paintRect) OVERRID E 97 virtual void invalidateContentsAndRootView(const IntRect& paintRect) OVERRID E
(...skipping 247 matching lines...) Expand 10 before | Expand all | Expand 10 after
345 // A WebPagePopupImpl instance usually has two references. 345 // A WebPagePopupImpl instance usually has two references.
346 // - One owned by the instance itself. It represents the visible widget. 346 // - One owned by the instance itself. It represents the visible widget.
347 // - One owned by a WebViewImpl. It's released when the WebViewImpl ask the 347 // - One owned by a WebViewImpl. It's released when the WebViewImpl ask the
348 // WebPagePopupImpl to close. 348 // WebPagePopupImpl to close.
349 // We need them because the closing operation is asynchronous and the widget 349 // We need them because the closing operation is asynchronous and the widget
350 // can be closed while the WebViewImpl is unaware of it. 350 // can be closed while the WebViewImpl is unaware of it.
351 return adoptRef(new WebPagePopupImpl(client)).leakRef(); 351 return adoptRef(new WebPagePopupImpl(client)).leakRef();
352 } 352 }
353 353
354 } // namespace WebKit 354 } // namespace WebKit
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698