Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Side by Side Diff: Source/web/ChromeClientImpl.cpp

Issue 20191003: Route JS Error Info From Blink to Chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@gclient
Patch Set: Adam's requests Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 354 matching lines...) Expand 10 before | Expand all | Expand 10 after
365 bool ChromeClientImpl::menubarVisible() 365 bool ChromeClientImpl::menubarVisible()
366 { 366 {
367 return m_menubarVisible; 367 return m_menubarVisible;
368 } 368 }
369 369
370 void ChromeClientImpl::setResizable(bool value) 370 void ChromeClientImpl::setResizable(bool value)
371 { 371 {
372 m_resizable = value; 372 m_resizable = value;
373 } 373 }
374 374
375 void ChromeClientImpl::addMessageToConsole(MessageSource source, 375 bool ChromeClientImpl::shouldReportDetailedMessageForContext(v8::Handle<v8::Cont ext> context)
376 MessageLevel level, 376 {
377 const String& message, 377 return m_webView->client() && m_webView->client()->shouldReportDetailedMessa geForContext(context);
378 unsigned lineNumber, 378 }
379 const String& sourceID) 379
380 bool ChromeClientImpl::shouldReportDetailedMessageForURL(const String& url)
381 {
382 return m_webView->client() && m_webView->client()->shouldReportDetailedMessa geForURL(url);
383 }
384
385 void ChromeClientImpl::addMessageToConsole(MessageSource source, MessageLevel le vel, const String& message, unsigned lineNumber, const String& sourceID, const S tring& details)
380 { 386 {
381 if (m_webView->client()) { 387 if (m_webView->client()) {
382 m_webView->client()->didAddMessageToConsole( 388 m_webView->client()->didAddMessageToConsole(
383 WebConsoleMessage(static_cast<WebConsoleMessage::Level>(level), mess age), 389 WebConsoleMessage(static_cast<WebConsoleMessage::Level>(level), mess age),
384 sourceID, 390 sourceID,
385 lineNumber); 391 lineNumber,
392 details);
386 } 393 }
387 } 394 }
388 395
389 bool ChromeClientImpl::canRunBeforeUnloadConfirmPanel() 396 bool ChromeClientImpl::canRunBeforeUnloadConfirmPanel()
390 { 397 {
391 return !!m_webView->client(); 398 return !!m_webView->client();
392 } 399 }
393 400
394 bool ChromeClientImpl::runBeforeUnloadConfirmPanel(const String& message, Frame* frame) 401 bool ChromeClientImpl::runBeforeUnloadConfirmPanel(const String& message, Frame* frame)
395 { 402 {
(...skipping 605 matching lines...) Expand 10 before | Expand all | Expand 10 after
1001 { 1008 {
1002 } 1009 }
1003 1010
1004 void NavigatorContentUtilsClientImpl::registerProtocolHandler(const String& sche me, const String& baseURL, const String& url, const String& title) 1011 void NavigatorContentUtilsClientImpl::registerProtocolHandler(const String& sche me, const String& baseURL, const String& url, const String& title)
1005 { 1012 {
1006 m_webView->client()->registerProtocolHandler(scheme, baseURL, url, title); 1013 m_webView->client()->registerProtocolHandler(scheme, baseURL, url, title);
1007 } 1014 }
1008 #endif 1015 #endif
1009 1016
1010 } // namespace WebKit 1017 } // namespace WebKit
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698