Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: webrtc/media/base/videocapturer.cc

Issue 2017443003: Implement timestamp translation/filter in VideoCapturer. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Add missing include of math.h. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/media/base/videocapturer.h ('k') | webrtc/webrtc_tests.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/base/videocapturer.cc
diff --git a/webrtc/media/base/videocapturer.cc b/webrtc/media/base/videocapturer.cc
index 96a605585509220b12875ecf993fc5010fe5e1cc..9d297bf9141e51941d606df52a3e9589754545b3 100644
--- a/webrtc/media/base/videocapturer.cc
+++ b/webrtc/media/base/videocapturer.cc
@@ -216,21 +216,27 @@ void VideoCapturer::OnSinkWantsChanged(const rtc::VideoSinkWants& wants) {
bool VideoCapturer::AdaptFrame(int width,
int height,
- // TODO(nisse): Switch to us unit.
- int64_t capture_time_ns,
+ int64_t camera_time_us,
+ int64_t system_time_us,
int* out_width,
int* out_height,
int* crop_width,
int* crop_height,
int* crop_x,
- int* crop_y) {
+ int* crop_y,
+ int64_t* translated_camera_time_us) {
+ int64_t offset_us =
+ translated_camera_time_us
+ ? timestamp_aligner_.UpdateOffset(camera_time_us, system_time_us)
+ : 0;
+
if (!broadcaster_.frame_wanted()) {
return false;
}
if (enable_video_adapter_ && !IsScreencast()) {
if (!video_adapter_.AdaptFrameResolution(
- width, height, capture_time_ns,
+ width, height, camera_time_us * rtc::kNumNanosecsPerMicrosec,
crop_width, crop_height, out_width, out_height)) {
// VideoAdapter dropped the frame.
return false;
@@ -245,6 +251,11 @@ bool VideoCapturer::AdaptFrame(int width,
*crop_x = 0;
*crop_y = 0;
}
+
+ if (translated_camera_time_us) {
+ *translated_camera_time_us = timestamp_aligner_.ClipTimestamp(
+ camera_time_us + offset_us, system_time_us);
+ }
return true;
}
@@ -257,10 +268,17 @@ void VideoCapturer::OnFrameCaptured(VideoCapturer*,
int crop_x;
int crop_y;
+ // TODO(nisse): We don't do timestamp translation on this input
+ // path. It seems straight-forward to enable translation, but that
+ // breaks the WebRtcVideoEngine2Test.PropagatesInputFrameTimestamp
+ // test. Probably not worth the effort to fix, instead, try to
+ // delete or refactor all code using VideoFrameFactory and
+ // SignalCapturedFrame.
if (!AdaptFrame(captured_frame->width, captured_frame->height,
- captured_frame->time_stamp,
+ captured_frame->time_stamp / rtc::kNumNanosecsPerMicrosec,
+ 0,
&out_width, &out_height,
- &crop_width, &crop_height, &crop_x, &crop_y)) {
+ &crop_width, &crop_height, &crop_x, &crop_y, nullptr)) {
return;
}
« no previous file with comments | « webrtc/media/base/videocapturer.h ('k') | webrtc/webrtc_tests.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698