Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: README

Issue 2017373002: Update README a bit and add Contributing info (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: README
diff --git a/README b/README
index 52f6521ac6fbefc2d9d04a7fc13fb84197bb532a..ce2bf27fa3a6d65e820cfff6e769c11ebd85cdc6 100644
--- a/README
+++ b/README
@@ -1,11 +1,4 @@
-This package contains tools for working with Chromium development.
-
-The "gclient" wrapper knows how to keep this repository updated to
-the latest versions of these tools as found at:
-
- http://src.chromium.org/svn/trunk/tools/depot_tools
-
-This package contains:
+This package contains tools for working with Chromium development:
chrome-update-create-task.bat
Creates a scheduled task to do an automatic local chromium build every day.
@@ -25,10 +18,38 @@ This package contains:
More info at:
http://code.google.com/p/gclient/
-Note: svn and python will be installed automatically if not accessible (on
-Windows only).
+It updates itself automatically. To disable automatic updating, set the
iannucci 2016/07/19 01:33:07 It updates itself automatically when running the "
+environment variable DEPOT_TOOLS_UPDATE=0
-To update this distribution manually, run .\update_depot_tools.bat on Windows,
+To update package manually, run .\update_depot_tools.bat on Windows,
or ./update_depot_tools on Linux or Mac.
-To disable automatic updating, set the environment variable DEPOT_TOOLS_UPDATE=0
+Note: on Windows if svn and python are not accessible, they will be
+downloaded too.
iannucci 2016/07/19 01:33:07 svn, python and git
+
+
+## Contributing
+
+The "gclient" wrapper knows how to keep this repository updated to
+the latest versions of these tools as found at:
+
+ https://chromium.googlesource.com/chromium/tools/depot_tools.git
+
+To contribute change for review:
+
+ git new-branch <somename>
+ git add <yourchanges>
+ git commit
+ # find reviewers
+ git cl owners
+ git log <yourfiles>
+ # upload
+ git cl upload -r reviewer1@chromium.org,reviewer2
+ # open https://codereview.chromium.org/ and send mail
iannucci 2016/07/19 01:33:07 can also add --send-mail command line flag to this
+
+ # if change is approved, flag it to be commited
+ git cl set_commit
+ # if change needs more work
+ git rebase-update
+ ...
+ git cl upload
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698