Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1555)

Unified Diff: media/mojo/interfaces/service_factory.mojom

Issue 2016053003: Add audio_device_id in mojo media ServiceFactory CreateRenderer api. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Fixes according to comments. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/mojo/interfaces/service_factory.mojom
diff --git a/media/mojo/interfaces/service_factory.mojom b/media/mojo/interfaces/service_factory.mojom
index b55e284c226d2b321e52f0344897742237d34bd4..0ef1445753ce3e6785c0716ad70b0fe527dad21a 100644
--- a/media/mojo/interfaces/service_factory.mojom
+++ b/media/mojo/interfaces/service_factory.mojom
@@ -19,7 +19,11 @@ interface ServiceFactory {
CreateVideoDecoder(VideoDecoder& video_decoder);
// Creates a Renderer service.
- CreateRenderer(Renderer& renderer);
+ // Audio stream will be played on device_id, which is defined in
+ // media/audio/audio_device_description.h. If audio_device_id
+ // is empty, kDefaultDeviceId will be used.
+ CreateRenderer(Renderer& renderer,
+ string audio_device_id);
// Creates a ContentDecryptionModule service.
CreateCdm(ContentDecryptionModule& cdm);

Powered by Google App Engine
This is Rietveld 408576698