Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: media/mojo/interfaces/renderer.mojom

Issue 2016053003: Add audio_device_id in mojo media ServiceFactory CreateRenderer api. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mojo/interfaces/renderer.mojom
diff --git a/media/mojo/interfaces/renderer.mojom b/media/mojo/interfaces/renderer.mojom
index 1318bad6d0c03eb41f6e23b6de453388ee02de16..f3ef189cf28fbf2fa00667597edef449ced63fc5 100644
--- a/media/mojo/interfaces/renderer.mojom
+++ b/media/mojo/interfaces/renderer.mojom
@@ -11,9 +11,12 @@ import "ui/gfx/geometry/mojo/geometry.mojom";
interface Renderer {
// Initializes the Renderer with one or both of an audio and video stream,
// executing the callback with whether the initialization succeeded.
+ // Audio stream will be played on device_id, which is defined in
+ // media/audio/audio_device_description.h.
Initialize(RendererClient client,
DemuxerStream? audio,
- DemuxerStream? video) => (bool success);
+ DemuxerStream? video,
+ string device_id) => (bool success);
alokp 2016/05/27 04:43:08 It is possible to target a particular device when
xhwang 2016/05/27 06:06:35 +dalecurtis I am not super familiar with audio, b
alokp 2016/05/27 18:31:01 In that case you would provide an AudioRendererSin
// Discards any buffered data, executing callback when completed.
// NOTE: If an error occurs, RendererClient::OnError() can be called
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698