Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Side by Side Diff: media/mojo/services/service_factory_impl.cc

Issue 2016053003: Add audio_device_id in mojo media ServiceFactory CreateRenderer api. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Fixes according to comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/mojo/services/service_factory_impl.h" 5 #include "media/mojo/services/service_factory_impl.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/message_loop/message_loop.h" 8 #include "base/message_loop/message_loop.h"
9 #include "media/base/media_log.h" 9 #include "media/base/media_log.h"
10 #include "media/mojo/services/mojo_media_client.h" 10 #include "media/mojo/services/mojo_media_client.h"
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 } 74 }
75 75
76 void ServiceFactoryImpl::CreateVideoDecoder( 76 void ServiceFactoryImpl::CreateVideoDecoder(
77 mojom::VideoDecoderRequest request) { 77 mojom::VideoDecoderRequest request) {
78 #if defined(ENABLE_MOJO_VIDEO_DECODER) 78 #if defined(ENABLE_MOJO_VIDEO_DECODER)
79 new MojoVideoDecoderService(std::move(request), mojo_media_client_); 79 new MojoVideoDecoderService(std::move(request), mojo_media_client_);
80 #endif // defined(ENABLE_MOJO_VIDEO_DECODER) 80 #endif // defined(ENABLE_MOJO_VIDEO_DECODER)
81 } 81 }
82 82
83 void ServiceFactoryImpl::CreateRenderer( 83 void ServiceFactoryImpl::CreateRenderer(
84 mojo::InterfaceRequest<mojom::Renderer> request) { 84 mojo::InterfaceRequest<mojom::Renderer> request,
85 const std::string& audio_device_id) {
85 #if defined(ENABLE_MOJO_RENDERER) 86 #if defined(ENABLE_MOJO_RENDERER)
86 // The created object is owned by the pipe. 87 // The created object is owned by the pipe.
87 // The audio and video sinks are owned by the client. 88 // The audio and video sinks are owned by the client.
88 scoped_refptr<base::SingleThreadTaskRunner> task_runner( 89 scoped_refptr<base::SingleThreadTaskRunner> task_runner(
89 base::MessageLoop::current()->task_runner()); 90 base::MessageLoop::current()->task_runner());
90 AudioRendererSink* audio_renderer_sink =
91 mojo_media_client_->CreateAudioRendererSink();
92 VideoRendererSink* video_renderer_sink =
93 mojo_media_client_->CreateVideoRendererSink(task_runner);
94 91
95 RendererFactory* renderer_factory = GetRendererFactory(); 92 std::unique_ptr<Renderer> renderer =
96 if (!renderer_factory) 93 mojo_media_client_->CreateRenderer(task_runner, media_log_,
97 return; 94 audio_device_id);
98
99 std::unique_ptr<Renderer> renderer = renderer_factory->CreateRenderer(
100 task_runner, task_runner, audio_renderer_sink, video_renderer_sink,
101 RequestSurfaceCB());
102 if (!renderer) { 95 if (!renderer) {
103 LOG(ERROR) << "Renderer creation failed."; 96 LOG(ERROR) << "Renderer creation failed.";
104 return; 97 return;
105 } 98 }
106 99
107 new MojoRendererService(cdm_service_context_.GetWeakPtr(), 100 new MojoRendererService(cdm_service_context_.GetWeakPtr(),
108 std::move(renderer), std::move(request)); 101 std::move(renderer), std::move(request));
109 #endif // defined(ENABLE_MOJO_RENDERER) 102 #endif // defined(ENABLE_MOJO_RENDERER)
110 } 103 }
111 104
112 void ServiceFactoryImpl::CreateCdm( 105 void ServiceFactoryImpl::CreateCdm(
113 mojo::InterfaceRequest<mojom::ContentDecryptionModule> request) { 106 mojo::InterfaceRequest<mojom::ContentDecryptionModule> request) {
114 #if defined(ENABLE_MOJO_CDM) 107 #if defined(ENABLE_MOJO_CDM)
115 CdmFactory* cdm_factory = GetCdmFactory(); 108 CdmFactory* cdm_factory = GetCdmFactory();
116 if (!cdm_factory) 109 if (!cdm_factory)
117 return; 110 return;
118 111
119 // The created object is owned by the pipe. 112 // The created object is owned by the pipe.
120 new MojoCdmService(cdm_service_context_.GetWeakPtr(), cdm_factory, 113 new MojoCdmService(cdm_service_context_.GetWeakPtr(), cdm_factory,
121 std::move(request)); 114 std::move(request));
122 #endif // defined(ENABLE_MOJO_CDM) 115 #endif // defined(ENABLE_MOJO_CDM)
123 } 116 }
124 117
125 #if defined(ENABLE_MOJO_RENDERER)
126 RendererFactory* ServiceFactoryImpl::GetRendererFactory() {
127 if (!renderer_factory_) {
128 renderer_factory_ = mojo_media_client_->CreateRendererFactory(media_log_);
129 LOG_IF(ERROR, !renderer_factory_) << "RendererFactory not available.";
130 }
131 return renderer_factory_.get();
132 }
133 #endif // defined(ENABLE_MOJO_RENDERER)
134
135 #if defined(ENABLE_MOJO_CDM) 118 #if defined(ENABLE_MOJO_CDM)
136 CdmFactory* ServiceFactoryImpl::GetCdmFactory() { 119 CdmFactory* ServiceFactoryImpl::GetCdmFactory() {
137 if (!cdm_factory_) { 120 if (!cdm_factory_) {
138 cdm_factory_ = mojo_media_client_->CreateCdmFactory(interfaces_); 121 cdm_factory_ = mojo_media_client_->CreateCdmFactory(interfaces_);
139 LOG_IF(ERROR, !cdm_factory_) << "CdmFactory not available."; 122 LOG_IF(ERROR, !cdm_factory_) << "CdmFactory not available.";
140 } 123 }
141 return cdm_factory_.get(); 124 return cdm_factory_.get();
142 } 125 }
143 #endif // defined(ENABLE_MOJO_CDM) 126 #endif // defined(ENABLE_MOJO_CDM)
144 127
145 } // namespace media 128 } // namespace media
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698