Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2430)

Unified Diff: ui/keyboard/resources/elements/kb-key-codes.html

Issue 20145004: Switch from text insertion to key press and release events on the virtual k… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge with trunk. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/keyboard/resources/elements/kb-key-base.html ('k') | ui/keyboard/resources/elements/kb-keyboard.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/keyboard/resources/elements/kb-key-codes.html
diff --git a/ui/keyboard/resources/elements/kb-key-codes.html b/ui/keyboard/resources/elements/kb-key-codes.html
index cf1a7c23fa3a0369828f1376f7427fc314b42dc7..b8353ecd938e45a889fd4a5c6bf8b4327d78f74b 100644
--- a/ui/keyboard/resources/elements/kb-key-codes.html
+++ b/ui/keyboard/resources/elements/kb-key-codes.html
@@ -7,6 +7,9 @@
<polymer-element name="kb-key-codes">
<script>
(function() {
+ // Each virtual key event is assigned a unique ID.
+ var nextRequestID = 0;
+
// Keycodes have been deprecated in the KeyEvent specification, but are
// nonetheless required to support legacy web content. The Keycodes in the
// following table are based on subset of US-EN 101-key keyboard. These
@@ -139,31 +142,36 @@
/**
* Creates a virtual key event for use with the keyboard extension API.
- * @param {kb-key} key Instance of the kb-key element being pressed or
- * released.
+ * See http://www.w3.org/TR/DOM-Level-3-Events/#events-KeyboardEvent.
+ * @param {Object} detail Attribute of the key being pressed or released.
* @param {string} type The type of key event, which may be keydown
- * or keyreleased.
- * @return {keyCode: numeric,
- * modifiers: Array.<string>,
- * type: string,
- * value: string}
+ * or keyup.
+ * @return {?KeyboardEvent} A KeyboardEvent object, or undefined on
+ * failure.
*/
- CreateVirtualKeyEvent: function(key, type) {
- var keyCode = key.keyCode;
- var shiftModifier = key.shiftModifier;
+ createVirtualKeyEvent: function(detail, type) {
+ var char = detail.char;
+ if (!char || char.length != 1) {
+ console.error('Invalid key. Expected single character.');
+ return;
+ }
+ var keyCode = detail.keyCode;
+ var shiftModifier = detail.shiftModifier;
if (keyCode == undefined) {
- var state = this.GetKeyCodeAndModifiers(key.charValue);
- keyCode = state.keyCode;
- shiftModifier = state.shiftModifier;
+ var state = this.GetKeyCodeAndModifiers(char);
+ if (state) {
+ keyCode = state.keyCode;
+ shiftModifier = state.shiftModifier;
+ } else {
+ keyCode = 0;
+ shiftModifier = false;
+ }
}
- var modifiers = [];
- if (shiftModifier)
- modifiers.push('shiftKey');
return {
- keyCode: keyCode,
- modifiers: modifiers,
type: type,
- value: key.charValue,
+ charValue: char.charCodeAt(0),
+ keyCode: keyCode,
+ shiftKey: shiftModifier
};
},
});
« no previous file with comments | « ui/keyboard/resources/elements/kb-key-base.html ('k') | ui/keyboard/resources/elements/kb-keyboard.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698